Mirror intel/llvm commits #2808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unified Runtime -> intel/llvm Repo Move NoticeInformationThe source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory, The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime. The contribution guide will be updated with new instructions for contributing to Unified Runtime. PR MigrationAll open PRs including this one will be marked with the Should you wish to continue with your PR you will need to migrate it to intel/llvm. If your PR should remain open and not be closed automatically, you can remove the This is an automated comment. |
The problem here is that the macro is actually handled by glibc and value `3` isn't supported with older compiler/glibc combinations, causing warnings about the macro redefinition. We still have to support older compilers/glibc and therefore two changes were made: - UR skips setting their own `_FORTIFY_SOURCE` in favor of a global one if it is built as part of LLVM (i.e. not standalone) - Before setting `_FORTIFY_SOURCE` globally we check the compiler and fallback to value `2` for older gcc
The wording of the spec was a bit confusing, so it has been clarified. The conformance test was also updated to be more robust, which unfortunately exposes failures in HIP and Cuda.
In DX11 Texture1D and Texture3D cannot be shared between process or devices, so only Texture2D is used but its layout is adapted (height = 1 for 1D and ArraySlices = depth for 3D) for the interop purposes and testing 1D and 3D image operations on it in the SYCL kernel. The new DXGI adapter selection fixes issues with non-matching devices between DX and SYCL which also failed the DX12 tests when more than 1 potential adapter is visible to DirectX. Ideally the introduction of LUIDs to SYCL will resolve that completely when they are properly matched. The future flow should change to - 1) create SYCL device (so the device selection itself can be manipulated via `ONEAPI_DEVICE_SELECTOR`) , 2) get DXGI adapter for creating a DX logical device (D3D11 or D3D12) by matching adapter LUIDs (this is going to depend on a LUID device info query extension for SYCL). Some notes on synchronisation: - IKeyedMutex is required for synchronising the access to the shared resource (texture) between devices or processes. - Currently the SYCL queue calls wait after submission to execute immediately and block until completion, but we can use ID3D11Fence imported in SYCL to signal the completion of the work to D3D11 via SYCL in the future when this kind of interop is considered.
This is needed so that we can enable V2 adapter by default on certain platforms: intel/llvm#19333 The reason is that we need to load both adapters (legacy and v2) to check the device version. However, loading v2 adapter causes L0 loader to emit logs for all API calls (if ZE_DEBUG=1 is set). Since the legacy adapter used different logic for printing API calls, this would result in printing the same logs twice. This patch fixes that.
github-actions
bot
force-pushed
the
mirror-commits-
branch
from
d68fc64 to
cfc35c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action