Mirror intel/llvm commits #2814
Conversation
`UR_CHECK_ERROR` throws an exception so we can't use it from a destructor. Since devices only get released at application shutdown, there's not much we can do if `nvmlShutdown` reports an error, and the OS will promptly cleanup anything left as it tears down the process anyway. So just skip checking the error code from `nvmlShutdown`, this is already what we do for other cleanup/shutdown in this destructor. Fixes: intel/llvm#19500
The following entry points are implemented here: * `DEVICE_INFO_GLOBAL_VARIABLE_SUPPORT` (is now true) * `urProgramGetGlobalVariablePointer` * `urEnqueueDeviceGlobalVariableRead` * `urEnqueueDeviceGlobalVariableWrite` In addition, the enqueue interface has been moved out into a helper function and the program handler now handles the `@global_id_mapping` property.
The issue causing the crash upstream has been fixed (it was an unhandled llvm::Error), so we can now delete events properly.
Unified Runtime -> intel/llvm Repo Move NoticeInformationThe source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory, The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime. The contribution guide will be updated with new instructions for contributing to Unified Runtime. PR MigrationAll open PRs including this one will be marked with the Should you wish to continue with your PR you will need to migrate it to intel/llvm. If your PR should remain open and not be closed automatically, you can remove the This is an automated comment. |
3 participants
Automated changes by create-pull-request GitHub action