Skip to content

Conversation

kbenzie
Copy link
Contributor

@kbenzie kbenzie commented Aug 6, 2025

Automated changes by create-pull-request GitHub action

sarnex and others added 4 commits August 6, 2025 00:44
Unify OpenCL detection logic to improve packaging for Linux distros.

Right now two different projects, `opencl-aot` and the UR OCL plugin
depend on OpenCL (both the headers and the ICD loader)

They both have their own detection logic and CMake variables to use a
preinstalled version.

Move the detection logic to using the standard `find_package` and unify
the logic.

There are now no CMake variables to specify the repo, commit or install
directory. If `find_package` fails because the install is in a weird
location, the user should add the path to `CMAKE_MODULE_PATH`. The user
can use `FETCHCONTENT_SOURCE_DIR_ocl-headers` or
`FETCHCONTENT_SOURCE_DIR_ocl-icd` if they really want a custom repo
location without it being installed on the system.

Improvement of our OpenCL handling was directly requested by NixOS
developers, see below issue.

Issue: intel/llvm#19635

---------

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Typically these are cribbed from the CUDA + Hip adapters, but only when
it makes sense as a default for l0 as well (or pertains to something
we're already reporting no support for in the case of the device
partition stuff).
and return an error if urQueueCreateWithNativeHandle is called with
`ze_command_queue_handle_t`.

V2 adapter does not support non-immediate or out-of-order command lists.
Document this in the extension doc.

Currently, there is no way to check whether a command-list is in order
or not programatically.

---------

Co-authored-by: John Pennycook <john.pennycook@intel.com>
@kbenzie kbenzie requested a review from a team as a code owner August 6, 2025 00:44
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Unified Runtime -> intel/llvm Repo Move Notice

Information

The source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory,
all future development will now be carried out there. This was done in intel/llvm#17043.

The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime.

The contribution guide will be updated with new instructions for contributing to Unified Runtime.

PR Migration

All open PRs including this one will be marked with the auto-close label and shall be automatically closed after 30 days.

Should you wish to continue with your PR you will need to migrate it to intel/llvm.
We have provided a script to help automate this process.

If your PR should remain open and not be closed automatically, you can remove the auto-close label.


This is an automated comment.

@aarongreig aarongreig merged commit 4dfe411 into main Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants