[UR] Add UI information #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
reviewed
May 26, 2023
scripts/core/INTRO.rst
Outdated
Comment on lines
312
to
313
| `-DVAL_USE_LIBBACKTRACE_BACKTRACE=ON`, | ||
| `-DUR_ENABLE_TRACING=ON` |
Contributor
There was a problem hiding this comment.
reStructureText inline monospace should be wrapped in double backticks
Suggested change
| `-DVAL_USE_LIBBACKTRACE_BACKTRACE=ON`, | |
| `-DUR_ENABLE_TRACING=ON` | |
| ``-DVAL_USE_LIBBACKTRACE_BACKTRACE=ON``, | |
| ``-DUR_ENABLE_TRACING=ON`` |
PatKamin
reviewed
May 29, 2023
pbalcer
reviewed
May 29, 2023
scripts/core/INTRO.rst
Outdated
| --------------------- | ||
|
|
||
| The Unified Runtime API can log unique device identifiers. | ||
| For security and functionality reasons, the user can enable and disable the logging of identifiers |
Contributor
There was a problem hiding this comment.
Suggested change
| For security and functionality reasons, the user can enable and disable the logging of identifiers | |
| For security and functionality reasons, users can enable and disable the logging of identifiers |
scripts/core/INTRO.rst
Outdated
| --------------------- | ||
|
|
||
| The Unified Runtime API can log unique device identifiers. | ||
| For security and functionality reasons, the user can enable and disable the logging of identifiers |
Contributor
There was a problem hiding this comment.
This is off by default. So instead, I think we can simply say:
Unified Runtime may create logs containing Personally Identifiable Information (PII) in the form of unique device identifiers during its use. This capability is turned off by default. Please refer to the Logging section above for more information.
Or maybe this should just be a sentence in the logging section?
kbenzie
approved these changes
May 29, 2023
pbalcer
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.