[ur] Actually fail when RST validation finds an error #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veselypeta
approved these changes
Jun 7, 2023
martygrant
approved these changes
Jun 7, 2023
omarahmed1111
approved these changes
Jun 7, 2023
Following on from oneapi-src#569 and oneapi-src#579 with the goal of failing the build when the generation scripts have errors, this patch introduces exceptions to the `_generate_valid_rst` where messages containing `error :` were being printed.
kbenzie
force-pushed
the
benie/add-validate-rst-exceptions
branch
from
5684735 to
f439fbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #569 and #579 with the goal of failing the build when
the generation scripts have errors, this patch introduces exceptions to
the
_generate_valid_rstwhere messages containingerror :were beingprinted.