[Exp][Bindless Images] Experimental Bindless Images #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacault
changed the title
kbenzie
suggested changes
Jun 12, 2023
JackAKirk
reviewed
Jun 12, 2023
JackAKirk
reviewed
Jun 12, 2023
veselypeta
reviewed
Jun 12, 2023
Contributor
veselypeta
left a comment
veselypeta
left a comment
There was a problem hiding this comment.
Looks good. I've added some suggestions about the return codes - I think some of them will be automatically added by the API generator, if not feel free to include them. Also please disregard my naming changes if you disagree - it's your experimental feature after all 👍
isaacault
force-pushed
the
bindless_images
branch
from
a007d4a to
f5456c6
Compare
veselypeta
added
the
experimental
veselypeta
approved these changes
Jun 13, 2023
Contributor
veselypeta
left a comment
veselypeta
left a comment
There was a problem hiding this comment.
LGTM. Just one tiny thing 👍
isaacault
force-pushed
the
bindless_images
branch
from
f5456c6 to
c4fc7f0
Compare
isaacault
force-pushed
the
bindless_images
branch
from
c4fc7f0 to
11e504e
Compare
kbenzie
approved these changes
Jun 14, 2023
JackAKirk
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental support for bindless images in Unified Runtime.
This feature is to add support for the experimental implementation of bindless images extension #9665 in DPC++ after Port CUDA plugin to Unified Runtime #9512 is merged.