Skip to content

Conversation

@rdeodhar
Copy link
Contributor

This change adds the definitions necessary for two new functions: USMImport and USMRelease.

USMImport converts host system memory into something akin to USM host memory.
USMRelease undoes the effect of a previous USMImport.

This functionality is used by SYCL to import/release host memory to speed up host <-> device data transfers.

@rdeodhar
Copy link
Contributor Author

The primary changes in this PR are the .rst file and the .yml file.
I'm not sure if all the necessary files are being generated because the generate step causes these errors to appear:

Generating HTML...
Running Sphinx v4.3.2
sphinx-build returned non-zero error code.
--- output ---
Failed to generate specification.
gmake[7]: *** [CMakeFiles/generate-code.dir/build.make:70: CMakeFiles/generate-code] Error 1
gmake[7]: Leaving directory '/iusers/rdeodhar/cmplr/ur_l0import1/llvm/build'
gmake[6]: *** [CMakeFiles/Makefile2:1569: CMakeFiles/generate-code.dir/all] Error 2
gmake[6]: Leaving directory '/iusers/rdeodhar/cmplr/ur_l0import1/llvm/build'
gmake[5]: *** [CMakeFiles/Makefile2:1576: CMakeFiles/generate-code.dir/rule] Error 2
gmake[5]: Leaving directory '/iusers/rdeodhar/cmplr/ur_l0import1/llvm/build'
gmake[4]: *** [Makefile:569: generate-code] Error 2
gmake[4]: Leaving directory '/iusers/rdeodhar/cmplr/ur_l0import1/llvm/build'
make[3]: *** [CMakeFiles/generate.dir/build.make:70: CMakeFiles/generate] Error 2
make[3]: Leaving directory '/iusers/rdeodhar/cmplr/ur_l0import1/llvm/build'
make[2]: *** [CMakeFiles/Makefile2:1595: CMakeFiles/generate.dir/all] Error 2
make[2]: Leaving directory '/iusers/rdeodhar/cmplr/ur_l0import1/llvm/build'
make[1]: *** [CMakeFiles/Makefile2:1602: CMakeFiles/generate.dir/rule] Error 2
make[1]: Leaving directory '/iusers/rdeodhar/cmplr/ur_l0import1/llvm/build'
make: *** [Makefile:582: generate] Error 2
make: Leaving directory '/iusers/rdeodhar/cmplr/ur_l0import1/llvm/build'

@kbenzie
Copy link
Contributor

kbenzie commented Jun 15, 2023

This looks very similar to this which was fixed by this:

I've had a similar problem in the past. I was missing some sphinx dependency, and solved it with pip install -r third_party/requirements.txt.

@rdeodhar
Copy link
Contributor Author

Running "pip install -r third_party/requirements.txt" fixed the Sphinx problem. But I still have a problem with the ${x} prefix in the .rst file.

Copy link
Contributor

@veselypeta veselypeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@veselypeta veselypeta Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to block this PR, but could you refactor this to match the experimental features template in a follow up PR- see here

@kbenzie
Copy link
Contributor

kbenzie commented Jun 19, 2023

I'll look into resolving these merge conflicts and getting this merged.

@veselypeta veselypeta merged commit cfa949f into oneapi-src:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants