[EXP][CMD-BUFFER] Add read and write function definitions #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
suggested changes
Jun 22, 2023
mfrancepillois
force-pushed
the
maxime/command-buffer-read-write
branch
from
b460bbc to
fb3ab63
Compare
Bensuo
reviewed
Jun 22, 2023
Contributor
Bensuo
left a comment
Bensuo
left a comment
There was a problem hiding this comment.
LGTM, just some minor comments
kbenzie
reviewed
Jun 22, 2023
Contributor
kbenzie
left a comment
kbenzie
left a comment
There was a problem hiding this comment.
Does scripts/core/EXP-COMMAND-BUFFER.rst need updated?
mfrancepillois
force-pushed
the
maxime/command-buffer-read-write
branch
from
fb3ab63 to
7f57818
Compare
Bensuo
approved these changes
Jun 22, 2023
Contributor
Bensuo
left a comment
Bensuo
left a comment
There was a problem hiding this comment.
LGTM, just one minor comment!
mfrancepillois
force-pushed
the
maxime/command-buffer-read-write
branch
from
7f57818 to
85fabe8
Compare
Bensuo
approved these changes
Jun 22, 2023
veselypeta
suggested changes
Jun 23, 2023
Contributor
veselypeta
left a comment
veselypeta
left a comment
There was a problem hiding this comment.
LGMT - just blocking this to fix the registry.
kbenzie
suggested changes
Jun 23, 2023
Contributor
kbenzie
left a comment
kbenzie
left a comment
There was a problem hiding this comment.
One last change, otherwise looking good!
…buffer read and write
mfrancepillois
force-pushed
the
maxime/command-buffer-read-write
branch
from
85fabe8 to
9019018
Compare
veselypeta
approved these changes
Jun 23, 2023
kbenzie
approved these changes
Jun 23, 2023
EwanC
pushed a commit
to reble/llvm
that referenced
this pull request
Jun 27, 2023
Pulls in changes from #238 which requires bumping the UR commit to oneapi-src/unified-runtime#644 Co-authored-by: Maxime France-Pillois <maxime.francepillois@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new command-buffer functions for appending read and write commands for one-dimensional and rectangular buffers