Skip to content

[UR] Add extensibility to the rest of kernelSet* entrypoints #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
omarahmed1111 merged 1 commit into from
Jun 23, 2023
Merged

[UR] Add extensibility to the rest of kernelSet* entrypoints #645

omarahmed1111 merged 1 commit into from
Jun 23, 2023

Conversation

@omarahmed1111
Copy link
Contributor

@omarahmed1111 omarahmed1111 commented Jun 22, 2023 •
edited
Loading

Add pProperties to urKernelSetArgPointer - urKernelSetExecInfo - urKernelSetArgSampler entry-points

Resolves 572

@omarahmed1111 omarahmed1111 changed the title Add extensibility to the rest of kernelSet* entrypoints [UR] Add extensibility to the rest of kernelSet* entrypoints Jun 22, 2023
kbenzie
kbenzie reviewed Jun 22, 2023
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed urKernelSetArgValue and urKernelSetArgLocal.

@omarahmed1111 omarahmed1111 force-pushed the add_props_to_kernel_set_entrypoints branch from 0af3f18 to ac1d7d4 Compare June 22, 2023 16:28
@omarahmed1111
Copy link
Contributor Author

omarahmed1111 commented Jun 22, 2023

Looks like you missed urKernelSetArgValue and urKernelSetArgLocal.

Yup, added that.

@omarahmed1111
Copy link
Contributor Author

omarahmed1111 commented Jun 22, 2023

Do we need to add urKernelSetSpecializationConstants?

@omarahmed1111 omarahmed1111 force-pushed the add_props_to_kernel_set_entrypoints branch from ac1d7d4 to f37889f Compare June 22, 2023 16:34
@kbenzie
Copy link
Contributor

kbenzie commented Jun 22, 2023

Do we need to add urKernelSetSpecializationConstants?

No, this doesn't relate to kernel arguments.

@omarahmed1111 omarahmed1111 force-pushed the add_props_to_kernel_set_entrypoints branch from f37889f to 6da2001 Compare June 22, 2023 16:43
@omarahmed1111 omarahmed1111 requested a review from kbenzie June 23, 2023 10:07
kbenzie
kbenzie approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omarahmed1111 omarahmed1111 merged commit 7e16bb3 into oneapi-src:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kbenzie kbenzie kbenzie approved these changes

@veselypeta veselypeta veselypeta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SYCL RT request: need an API to provide memory access hint to urKernelSetArgMemObj

3 participants

@omarahmed1111 @kbenzie @veselypeta