Skip to content

Conversation

@callumfare
Copy link
Contributor

  • Make urInit and urTeardown loader-only, rename them to urLoaderInit and urLoaderTearDown
  • Split runtime.yml into loader.yml and adapter.yml
  • Add teardown method to layers so they can still cleanly tidy up any state, as they will no longer intercept the loader-only urLoaderTearDown.
  • Correct the validation layer's tracking of adapter handles, as urAdapterGet may either create the initial reference or increment it.
  • Track the number of in-use adapters in the validation layer. When no more adapters are in use, report all leaked handles. This allows reporting of leaks even if a user does not call urLoaderTeardown

Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being targeted for the upcoming release, so 0.7.1 (or something like that)?

@pbalcer pbalcer requested a review from kswiecicki August 9, 2023 12:52
@callumfare callumfare force-pushed the callum/loader_init branch 4 times, most recently from 7f696db to fa1a3e4 Compare August 10, 2023 12:50
@kbenzie
Copy link
Contributor

kbenzie commented Aug 16, 2023

Is this being targeted for the upcoming release, so 0.7.1 (or something like that)?

I don't think so, its too big a change for 2024.0 which 0.7.x is primarily for.

I've opened #806 to discuss defining a release process.

@callumfare callumfare force-pushed the callum/loader_init branch 2 times, most recently from 3619f1e to 5114b57 Compare August 25, 2023 15:54
@callumfare
Copy link
Contributor Author

Assuming this passes CI this should be ready to merge now - not sure if we're waiting for anything else before that happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants