[CUDA][EXP] CUDA adapter support for command buffers #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bensuo
commented
Oct 6, 2023
Bensuo
commented
- Implement initial subset of command buffer functions for CUDA
- Report command buffer extension as supported from device query
- Some additional methods and refactoring to reuse existing adapter code
Contributor
Author
|
Linked DPC++ PR: intel/llvm#11133 |
Bensuo
force-pushed
the
cuda-cmd-buffers
branch
from
91ac12b to
5fcf94e
Compare
jchlanda
reviewed
Oct 11, 2023
Contributor
jchlanda
left a comment
jchlanda
left a comment
There was a problem hiding this comment.
I don't have an in depth view of this functionality, so my review is mostly style/nit, apologies.
ldrumm
suggested changes
Oct 12, 2023
Contributor
ldrumm
left a comment
ldrumm
left a comment
There was a problem hiding this comment.
I don't know anything about command buffers, so my review is in the small. I'll leave someone else to think about the higher level flow
Bensuo
force-pushed
the
cuda-cmd-buffers
branch
3 times, most recently
from
f30f960 to
44cb034
Compare
Bensuo
force-pushed
the
cuda-cmd-buffers
branch
3 times, most recently
from
0f0dd7d to
b70280f
Compare
Contributor
Author
jchlanda
approved these changes
Oct 19, 2023
Bensuo
force-pushed
the
cuda-cmd-buffers
branch
from
b70280f to
c3c349f
Compare
ldrumm
approved these changes
Oct 19, 2023
- Implement initial subset of command buffer functions for CUDA - Report command buffer extension as supported from device query - Some additional methods and refactoring to reuse existing adapter code
Bensuo
force-pushed
the
cuda-cmd-buffers
branch
from
c3c349f to
74f42f8
Compare
mfrancepillois
approved these changes
Oct 23, 2023
Contributor
added 2 commits
October 30, 2023 07:27
This is required after oneapi-src#961
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 3, 2023
Adds support for enabling CUDA backend with Sycl-Graph: - Enables Graph e2e tests with CUDA backend. Companion PR with CUDA UR adapter changes is here: oneapi-src/unified-runtime#932 --------- Co-authored-by: Ewan Crawford <ewan@codeplay.com> Co-authored-by: Julian Miller <julian.miller@intel.com> Co-authored-by: Ben Tracy <ben.tracy@codeplay.com> Co-authored-by: Kenneth Benzie (Benie) <k.benzie83@gmail.com> Co-authored-by: Maxime France-Pillois <maxime.francepillois@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.