README updates #22
Merged
README updates #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boydgreenfield
force-pushed
the
boyd/fix-readme-link
branch
from
cf9efff to
63460e6
Compare
boydgreenfield
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes:
Hardcode links in the README: For reasons I cannot determine, these relative links are broken when on https://github.com/onecodex/rust-bfield but work on https://github.com/onecodex/rust-bfield/blob/main/README.md (in the first, the notebook link is this invalid path
https://github.com/onecodex/rust-bfield/docs/notebook/calculate-parameters.ipynb. So, this just hardcodes the links. 😭Adds a missing Cargo docs link, removes another missing link
Adds clarifying language around false positives to the intro