-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optional --destination param on mount #203
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#! /bin/sh | ||
|
||
# this shell wrapper around the cli_fuse_tests.go to remind how to run the tests. | ||
# these tests are not run as part of CI since FUSE is unavailable via CircleCI. | ||
|
||
(cd .. && go build) | ||
|
||
go test -tags fuse_cli -list Mount |grep -v '^ok' |while read -r test_name; do | ||
umount /tmp/mmp | ||
rm -r /tmp/mmp /tmp/mmfs | ||
go test -v -tags fuse_cli -run '^'"${test_name}"'$' | ||
done |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use the bundle hash and write the bundle descriptor last or write a done marker file. The next time we can skip downloading the files and reused the json files downloaded.. ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the bundle descriptor and filelists are written to disk at the same time it's used to initialize the in-memory structures. #218 contains the change to read
${destination}/.datamon/
folder from disk into in-memory structures.since this implementation places the destination in a temporary directory that might vanish after the process exits, it's not clear where the reusable json files are to be stored... i suppose creating a subdirectory of
${HOME}/.datamon
, say${HOME}/.datamon/meta-cache
, is a reasonable option?creating a new issue to document the intent of these changes seems more likely to me than including them in this diff.