Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dedupe cmd Run funcs (stores) #224

Merged
merged 1 commit into from
Jul 18, 2019
Merged

dedupe cmd Run funcs (stores) #224

merged 1 commit into from
Jul 18, 2019

Conversation

ransomw1c
Copy link
Contributor

nominally toward #165 , this diff deduplicates creation of objects based on parameters in the Run: functions of the various cobra.Command structs in the cmd/CLI package.

this harmonization might in particular have implications for implementing IPC as discussed in this comment on #214 , the bundle update iss.

@ransomw1c ransomw1c force-pushed the i165-cmdstores--wip branch 3 times, most recently from ed1870e to 1d94231 Compare July 1, 2019 21:09
@ransomw1c ransomw1c changed the title [wip] dedupe cmd Run funcs (stores) dedupe cmd Run funcs (stores) Jul 1, 2019
@ransomw1c ransomw1c marked this pull request as ready for review July 1, 2019 21:09
@ransomw1c ransomw1c requested a review from kerneltime July 1, 2019 21:10
@ransomw1c ransomw1c mentioned this pull request Jul 16, 2019
Merged
@ransomw1c
dedupe cmd Run funcs
7c75353 
Signed-off-by: Ransom Williams <rwilliams@oneconcern.com>
@ransomw1c ransomw1c merged commit ed10679 into master Jul 18, 2019
@ransomw1c ransomw1c deleted the i165-cmdstores--wip branch July 18, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerneltime kerneltime kerneltime approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ransomw1c @kerneltime