Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce commit spam by moving container information elsewhere #941

Closed
onedr0p opened this issue Jan 2, 2024 · 2 comments · Fixed by #980
Closed

Reduce commit spam by moving container information elsewhere #941

onedr0p opened this issue Jan 2, 2024 · 2 comments · Fixed by #980

Comments

@onedr0p
Copy link
Owner

onedr0p commented Jan 2, 2024

While I love the idea of having these containers and badges it does come at an expense of having a lot of spam in the commit log. Ideally it would be great to move these to outside the README maybe in the Github wiki?

@rtrox
Copy link
Collaborator

rtrox commented Jan 26, 2024

Yea... this is getting sort of spammy, especially with all the minor version changes. contributor doesn't give me access to set up wiki pages, but if you want to get a skeleton wiki set up, I should be able to work on the automation to write there. It looks like the wiki is just a hidden git repo, so it shouldn't be too crazy to get it moved over:

https://docs.github.com/en/communities/documenting-your-project-with-wikis/adding-or-editing-wiki-pages#adding-or-editing-wiki-pages-locally

@onedr0p
Copy link
Owner Author

onedr0p commented Mar 12, 2024

@rtrox I wonder if it's better to just remove it, while not ideal people can visit the packages section to see images and tags.

The wiki idea isn't great because it's also moving it out of sight like the packages section would be. I think this can be revisited when shields.io supports GHCR?

It would kind of work like this https://github.com/eggplants/ghcr-badge (not sure if we want to use this project though)

See this for an example: https://ghcr-badge.egpl.dev/onedr0p/prowlarr/tags

Using shields.io / ghcr-badge.egpl.dev would make it so commits are only added on addition or removal of images.

rtrox added a commit to rtrox/onedr0p-containers that referenced this issue Mar 12, 2024
Signed-off-by: Russell Troxel <russell.troxel@segment.com>
rtrox added a commit that referenced this issue Mar 12, 2024
Signed-off-by: Russell Troxel <russell.troxel@segment.com>
onedr0p pushed a commit that referenced this issue Mar 13, 2024
* Fix #941: omit tags from README to minimize spam

Signed-off-by: Russell Troxel <russell.troxel@segment.com>

* Re-render readme with proper env vars

Signed-off-by: Russell Troxel <russell.troxel@segment.com>

---------

Signed-off-by: Russell Troxel <russell.troxel@segment.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants