Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/support bazarr #214

Merged
merged 23 commits into from
Oct 8, 2023
Merged

Feature/support bazarr #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
1c19cdf
remove the branch requirement to run tests
phyzical Sep 12, 2023
376ad1b
lint makefile
phyzical Sep 12, 2023
2f87008
add bazarr to readme
phyzical Sep 12, 2023
cbbcc5e
also comment out release image as we only want tests to happen
phyzical Sep 12, 2023
bb45c0d
initial changes to start attempting to pull bazarr i thinnk?
phyzical Sep 12, 2023
ffe95c5
make it only run the tests, but skip release image
phyzical Sep 12, 2023
8615eab
add a genric makefile to build container localy, run and test
phyzical Sep 12, 2023
c277a68
rename build command
phyzical Sep 12, 2023
9459374
add pic and grafana dashboard adjustments
phyzical Sep 23, 2023
41f16d9
refactor metrics to just be contained within 1 class
phyzical Sep 23, 2023
7c4bcce
add logic to allow csv values to params
phyzical Sep 23, 2023
099f367
remove some todos
phyzical Sep 23, 2023
5a928d5
make api version optional
phyzical Sep 26, 2023
2c79ae1
adjust makefile to auto kill and start
phyzical Sep 26, 2023
be603a5
remove now invalid test
phyzical Sep 26, 2023
90b2c90
add a test for no api version instead
phyzical Sep 26, 2023
f5e33fd
add a test to enforce csv params moving forward
phyzical Sep 26, 2023
1407062
add saml payloads for all endpoints, add test that mocks and verifies…
phyzical Sep 26, 2023
8cba7cf
Update .env.dist
onedr0p Oct 3, 2023
c7345f0
Update .gitignore
onedr0p Oct 3, 2023
e8d3181
Update internal/client/client.go
phyzical Oct 4, 2023
374431e
add a tidy task
phyzical Oct 4, 2023
c6930a7
Merge branch 'feature/support-bazarr' of github.com:phyzical/exportar…
phyzical Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .env.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
APP_API_KEY=RADARR_API_KEY
APP_URL=RADARR_URL
APP_NAME=radarr
Binary file added .github/images/dashboard-bazarr.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ name: ci

on:
push:
branches:
- master
pull_request:
types:
- opened
Expand All @@ -24,7 +22,7 @@ jobs:
release-image:
runs-on: ubuntu-latest
needs: tests
if: github.event_name == 'push'
if: github.event_name == 'push' && github.ref_name == 'master'
steps:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should mean it'll run the tests per commit but shouldn't try to make a release.

Can revert if preferred

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@rtrox rtrox Oct 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, actually -- this change is a problem :-/ . The on conditions in an action are an OR between it's children, so it was already running on pushes to master OR pull_requests, with the if condition here ensuring that we only released images on a push to master.

So what this change is actually doing is making it so that we'll only run this workflow on pull_requests, and therefore never build images inside this workflow (so the only built images would come from the tagged release workflow, we'd have no updates to the master tag).

Let's revert this file, everything else looks good.

- name: Checkout
uses: actions/checkout@v3
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,6 @@
# Operating System
.DS_Store
**/.DS_Store

.env
covprofile
36 changes: 18 additions & 18 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# exportarr

AIO Prometheus Exporter for Sonarr, Radarr, Lidarr, Prowlarr, Readarr, and Sabnzbd
AIO Prometheus Exporter for Sonarr, Radarr, Lidarr, Prowlarr, Readarr, Bazarr and Sabnzbd

[![Go Report Card](https://goreportcard.com/badge/github.com/onedr0p/exportarr)](https://goreportcard.com/report/github.com/onedr0p/exportarr)

Expand Down Expand Up @@ -53,23 +53,23 @@ Visit http://127.0.0.1:9707/metrics to see the app metrics

## Configuration

| Environment Variable | CLI Flag | Description | Default | Required |
|:----------------------------:|--------------------------------|----------------------------------------------------------------|-----------|:--------:|
| `PORT` | `--port` or `-p` | The port exportarr will listen on | | ✅ |
| `URL` | `--url` or `-u` | The full URL to Sonarr, Radarr, or Lidarr | | ✅ |
| `API_KEY` | `--api-key` or `-a` | API Key for Sonarr, Radarr or Lidarr | | ❌ |
| `API_KEY_FILE` | `--api-key-file` | API Key file location for Sonarr, Radarr or Lidarr | | ❌ |
| `CONFIG` | `--config` or `-c` | Path to Sonarr, Radarr or Lidarr's `config.xml` (advanced) | | ❌ |
| `INTERFACE` | `--interface` or `-i` | The interface IP exportarr will listen on | `0.0.0.0` | ❌ |
| `LOG_LEVEL` | `--log-level` or `-l` | Set the default Log Level | `INFO` | ❌ |
| `DISABLE_SSL_VERIFY` | `--disable-ssl-verify` | Set to `true` to disable SSL verification | `false` | ❌ |
| `AUTH_PASSWORD` | `--auth-password` | Set to your basic or form auth password | | ❌ |
| `AUTH_USERNAME` | `--auth-username` | Set to your basic or form auth username | | ❌ |
| `FORM_AUTH` | `--form-auth` | Use Form Auth instead of basic auth | `false` | ❌ |
| `ENABLE_ADDITIONAL_METRICS` | `--enable-additional-metrics` | Set to `true` to enable gathering of additional metrics (slow) | `false` | ❌ |
| `ENABLE_UNKNOWN_QUEUE_ITEMS` | `--enable-unknown-queue-items` | Set to `true` to enable gathering unknown queue items | `false` | ❌ |
| `PROWLARR__BACKFILL` | `--backfill` | Set to `true` to enable backfill of historical metrics | `false` | ❌ |
| `PROWLARR__BACKFILL_SINCE_DATE` | `--backfill-since-date` | Set a date from which to start the backfill | `1970-01-01` (epoch) | ❌ |
| Environment Variable | CLI Flag | Description | Default | Required |
| :-----------------------------: | ------------------------------ | -------------------------------------------------------------- | -------------------- | :------: |
| `PORT` | `--port` or `-p` | The port exportarr will listen on | | ✅ |
| `URL` | `--url` or `-u` | The full URL to Sonarr, Radarr, or Lidarr | | ✅ |
| `API_KEY` | `--api-key` or `-a` | API Key for Sonarr, Radarr or Lidarr | | ❌ |
| `API_KEY_FILE` | `--api-key-file` | API Key file location for Sonarr, Radarr or Lidarr | | ❌ |
| `CONFIG` | `--config` or `-c` | Path to Sonarr, Radarr or Lidarr's `config.xml` (advanced) | | ❌ |
| `INTERFACE` | `--interface` or `-i` | The interface IP exportarr will listen on | `0.0.0.0` | ❌ |
| `LOG_LEVEL` | `--log-level` or `-l` | Set the default Log Level | `INFO` | ❌ |
| `DISABLE_SSL_VERIFY` | `--disable-ssl-verify` | Set to `true` to disable SSL verification | `false` | ❌ |
| `AUTH_PASSWORD` | `--auth-password` | Set to your basic or form auth password | | ❌ |
| `AUTH_USERNAME` | `--auth-username` | Set to your basic or form auth username | | ❌ |
| `FORM_AUTH` | `--form-auth` | Use Form Auth instead of basic auth | `false` | ❌ |
| `ENABLE_ADDITIONAL_METRICS` | `--enable-additional-metrics` | Set to `true` to enable gathering of additional metrics (slow) | `false` | ❌ |
| `ENABLE_UNKNOWN_QUEUE_ITEMS` | `--enable-unknown-queue-items` | Set to `true` to enable gathering unknown queue items | `false` | ❌ |
| `PROWLARR__BACKFILL` | `--backfill` | Set to `true` to enable backfill of historical metrics | `false` | ❌ |
| `PROWLARR__BACKFILL_SINCE_DATE` | `--backfill-since-date` | Set a date from which to start the backfill | `1970-01-01` (epoch) | ❌ |
onedr0p marked this conversation as resolved.
Show resolved Hide resolved

### Prowlarr Backfill

Expand Down
Loading