deps: replace python-lzo by lzallright. #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once we get this in, we can tag it with a new version and perform the release locally so we're clear on unblob side to fully get rid of python-lzo. Subsequent work on improving ubireader can happen afterwards (see #75). |
|
This also means dropping Python 2 support. |
vlaci
approved these changes
May 12, 2023
We proposed to move away from python-lzo because: - it doesn't have a wheel, so you still need a C compiler and lzo sources - licensing issues This commit replace python-lzo with https://github.com/vlaci/lzallright, a Python binding for https://crates.io/crates/lzokay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We proposed to move away from python-lzo because:
This commit replace python-lzo with https://github.com/vlaci/lzallright, a Python binding for https://crates.io/crates/lzokay