Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to poetry #78

Merged
merged 4 commits into from
May 15, 2023
Merged

Move to poetry #78

merged 4 commits into from
May 15, 2023

Conversation

qkaiser
Copy link
Contributor

@qkaiser qkaiser commented May 13, 2023

This MR migrate ubi-reader from setuptools to Poetry and setup a CI job to release to PyPi using our token.

The README has been updated accordingly. The documentation will be fully updated when we work towards establishing our baseline, with explanation on how to install Poetry / setup dev environment.

@qkaiser qkaiser merged commit 816669f into main May 15, 2023
@qkaiser qkaiser deleted the move-to-poetry branch May 15, 2023 15:40
@wh201906
Copy link

I think this PR breaks the compatibility for scripts using setup.py. It should be kept.
For example:
https://github.com/ReFirmLabs/binwalk/blob/cddfede795971045d99422bd7a9676c8803ec5ee/deps.sh#L116-L121

@vlaci
Copy link
Contributor

vlaci commented Nov 30, 2023

I'd be happier if noone would depend on pacakges having setup.py anymore. It is a deprecated practice for over two years. The correct way to install this project is to call pip similarly to how install_pip_package does a couple of lines below in the cited example.

@wh201906
Copy link

Hopefully other projects using this module will switch to the new install methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants