Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): adapt scripts so we can expose them thru poetry. #81

Merged
merged 1 commit into from
May 17, 2023

Conversation

qkaiser
Copy link
Contributor

@qkaiser qkaiser commented May 16, 2023

Moved the scripts within the package and renamed them with the right Python extension. They could not be imported properly before since they were lacking the .py extension and did not define a main function.

Tested with poetry build and pip install on the generated wheel locally against test files from unblob.

Moved the scripts within the package and renamed them with the right
Python extension. They could not be imported properly before since they
were lacking the .py extension and did not define a main function.

Tested with `poetry build` and `pip install` on the generated wheel
locally against test files from unblob.
@qkaiser qkaiser self-assigned this May 16, 2023
@qkaiser qkaiser requested review from vlaci and martonilles May 17, 2023 05:59
@vlaci vlaci merged commit 8e7c5ba into main May 17, 2023
@vlaci vlaci deleted the fix-scripts branch May 17, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants