Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Dockerfile #36

Closed
kissgyorgy opened this issue Nov 24, 2021 · 1 comment · Fixed by #110
Closed

Write Dockerfile #36

kissgyorgy opened this issue Nov 24, 2021 · 1 comment · Fixed by #110
Assignees
Labels
enhancement New feature or request

Comments

@kissgyorgy
Copy link
Contributor

A simple Dockerfile which has all required external dependencies installed.

@kissgyorgy kissgyorgy added this to the v1.0 - extraction milestone Nov 24, 2021
@qkaiser qkaiser added the enhancement New feature or request label Nov 26, 2021
@kukovecz
Copy link
Contributor

kukovecz commented Dec 3, 2021

Also, I think we need to refactor the gitub actions to build a container based on the Dockerfile and run the checks / tests inside that container.

The problem is, both the tests and checks github actions are doing a Install 3rd party from apt step. It would be easier to build a container and run everything from it.

The messy thing is, the checks sometimes does not need every package....
For example as I was checking this merge request: https://github.com/IoT-Inspector/unblob/pull/89/files
I just saw that it introduced a new dependency (lzop package) and this branch adds it to the tests github action, but it does not add it to the checks, and the checks can be executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants