Dockerfile + GitHub actions refactor #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukovecz
force-pushed
the
dockerfile
branch
4 times, most recently
from
d327e45
to
5c510fe
Compare
kukovecz
force-pushed
the
dockerfile
branch
4 times, most recently
from
7c7e0f0
to
bd4c5d5
Compare
kissgyorgy
requested changes
Dec 10, 2021
kissgyorgy
reviewed
Dec 10, 2021
kukovecz
force-pushed
the
dockerfile
branch
10 times, most recently
from
a4869f9
to
8a22166
Compare
Setup composite actions - These are a reusable workflow actions (like a function in a programming language) which helps prepare the targeted environment. This does every setup things before the actual workflows: - Install 3rd party applications with apt - Install pip + poetry - Install the virtual env with poetry - Git LFS pull - with cache Later this can be extended for other setup activities, or optimize this by doing caching for the whole virtualenv, etc. Main workflow - This is the main workflow which runs for every push and pull requests. It is doing the following jobs (in parallel): - check pre-commit - check pyright - run pytest
We want to cache everything for pip unconditionally, it will solve the dependencies for itself.
We can build the docker image and push it to the GitHub's container registry (ghcr.io) with the docker/build-push-action. Since we are in heavy development, currently this worflow was set up to run on main branch push events, and publish the container with the latest tag. Before the actual push, we can build the container locally for testig. It is using BuildKit, so multiple steps of the docker building are cached automatically: https://github.com/docker/build-push-action/blob/master/docs/advanced/test-before-push.md
kissgyorgy
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #36 by adding a Dockerfile (also doing a bigger refactoring on the whole GitHub action workflow chain).