Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry -> uv #1079

Merged
merged 10 commits into from
Jan 27, 2025
Merged

Poetry -> uv #1079

merged 10 commits into from
Jan 27, 2025

Conversation

vlaci
Copy link
Contributor

@vlaci vlaci commented Jan 13, 2025

It was surprisingly easy.

See #1034 for reasoning.

@vlaci vlaci force-pushed the uv branch 3 times, most recently from f681055 to 2d14814 Compare January 14, 2025 10:21
@qkaiser qkaiser self-requested a review January 14, 2025 12:58
e3krisztian
e3krisztian previously approved these changes Jan 21, 2025
@e3krisztian
Copy link
Contributor

Custom direnv code using poetry would break, but that is expected.

https://github.com/direnv/direnv/wiki/Python#uv

direnv/direnv#1250

qkaiser
qkaiser previously approved these changes Jan 24, 2025
Copy link
Contributor

@qkaiser qkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the move to uv, but would like to see @kukovecz comments addressed.

Used `uv-migrator`[^1] v2025.4.1 with `uv` 0.5.17

Edited by hand:

- uv-migrator did not pick up `atheris`'s python version constraint
- uv-migrator left out the `project.license` key
- build-backend is set to `hatchling` while rust code is not integrated[^2]

[^1]: https://github.com/stvnksslr/uv-migrator
[^2]: https://docs.astral.sh/uv/concepts/projects/init/#packaged-applications
@vlaci vlaci requested review from kukovecz and e3krisztian January 27, 2025 12:33
@vlaci vlaci dismissed stale reviews from qkaiser and e3krisztian January 27, 2025 12:34

moving out of draft

@vlaci vlaci marked this pull request as ready for review January 27, 2025 12:34
@vlaci vlaci added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 50b93c4 Jan 27, 2025
14 checks passed
@vlaci vlaci deleted the uv branch January 27, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants