Use separate file for handlers #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other test classes has their own fake_file fixtures, so let's not mix them up.
The aim here is to keep the possibility to parallelize handler executions. For this, each hander needs to have the ability to be exclusive with the given file, because they are doing file heavy operations (seek, read) all over the place. With this modification, each LimitedStartReader will read its own file descriptor instead of using the a common one. For each handler, we are already passing a different LimitedStartReader instance, which is good.
kukovecz
force-pushed
the
43-use-separate-file-for-handlers
branch
from
660a2c1
to
dd144d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43