fix(processing): delete successfully processed files. #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkaiser
added
enhancement
e3krisztian
reviewed
Feb 15, 2024
qkaiser
force-pushed
the
687-delete-temp-files
branch
from
25af548
to
f8660e0
Compare
A call to extract does not return any result if everything went well (no unhandled exception, no extraction errors). Under those conditions, we delete the source file if the --keep-extracted-chunks option is not set.
qkaiser
force-pushed
the
687-delete-temp-files
branch
from
f8660e0
to
a2be7a0
Compare
|
I would default to not deleting source files, a we can easily loose information and structure while doing so (there might be a reference to a file , which is further extracted and hence deleted). Even though not sure we would benefit much by deleting files compared to the complexity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the source file after extraction if the extraction was successful and the chunk being extracted covers the whole file.
Technical notes: A call to
extract()does not return anything if everything went well (no unhandled exception, no extraction errors). Under those conditions, we could delete the source file if the--keep-extracted-chunksoption is not set.Relying on
keep-extracted-chunksto make this decision is not ok since we're not technically operating on a chunk here. A chunk is something that was carved out of a file, here we're operating on a file that was extracted from an archive/filesystem.Closely related to #326, triggered by #687