Refactor processing, get rid of strategies.py #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlaci
reviewed
Dec 7, 2021
We decided that we don't want to implement the strategy abstraction right now. Moved search chunk related functionality into finder.py and deleted strategies.py The functions are ordered in the call order.
kissgyorgy
force-pushed
the
refact-processing
branch
from
a0f2ce9
to
0e5280f
Compare
Renamed the handler list to "ALL_HANDLERS_BY_PRIORITY" and made it public, as we import and use them multiple places. This is the official place to register new handlers. Load handlers lazily and cache the instantiation.
It's more natural to show those in decimal.
Wrote new unit tests during refactoring, coverage can be increased. Put the configuration in pyproject.toml, so everyone can run it with the same configuration.
Reason should be a better phrase.
kissgyorgy
force-pushed
the
refact-processing
branch
from
0e5280f
to
39004cd
Compare
vlaci
approved these changes
Dec 7, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided that we don't want to implement the strategy abstraction right now.
Moved search chunk related functionality into finder.py and deleted strategies.py and more small refacts.
Added unit tests and bumped test coverage requirement.