Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect permissions requested for workflow create #237

Merged

Conversation

Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Jan 7, 2021

What this PR does:

Fixes an issue where workflow execute button was sometimes hidden.

Which issue(s) this PR fixes:

Fixes onepanelio/onepanel#825

Special notes for your reviewer:

Before the create permission was checked for workspaces I combined it into workflows.

Checklist

Please check if applies

  • I have added/updated relevant unit tests
  • I have added/updated relevant documentation

Required

  • I accept to release these changes under the Apache 2.0 License

@Vafilor Vafilor added the kind/bug Something isn't working label Jan 7, 2021
@Vafilor Vafilor added this to the v0.17.0 milestone Jan 7, 2021
@rushtehrani rushtehrani merged commit 50a303b into onepanelio:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute workflow button missing
2 participants