Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support to provide parameters for workflow reruns #239

Merged
merged 9 commits into from
Jan 10, 2021

Conversation

Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Jan 7, 2021

What this PR does:

Adds support to customize a workflow when clicking the "rerun" button in a workflow list.
Also add a loading indicator to indicate when the workflow execution dialog is loading data

Which issue(s) this PR fixes:

Fixes onepanelio/core#

Special notes for your reviewer:

Checklist

Please check if applies

  • I have added/updated relevant unit tests
  • I have added/updated relevant documentation

Required

  • I accept to release these changes under the Apache 2.0 License

@Vafilor Vafilor added this to the v0.17.0 milestone Jan 7, 2021
@rushtehrani
Copy link
Contributor

Does this support changing the template as well? If so, does it default to the original Workflow's template?

@Vafilor Vafilor self-assigned this Jan 7, 2021
@Vafilor Vafilor added the kind/enhancement New feature or request label Jan 7, 2021
@Vafilor
Copy link
Contributor Author

Vafilor commented Jan 7, 2021

Does this support changing the template as well? If so, does it default to the original Workflow's template?

@rushtehrani Right now no, it just uses the same original template. This is something we can change though - do we want to allow changing the template?

@rushtehrani rushtehrani merged commit df8e658 into onepanelio:master Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants