Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional error handling for login page #279

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Mar 12, 2021

Before, any error was shown as the token being wrong. Now, additional errors are displayed accordingly.

What this PR does:

Which issue(s) this PR fixes:

Fixes onepanelio/onepanel#895

Special notes for your reviewer:

Checklist

Please check if applies

  • I have added/updated relevant unit tests
  • I have added/updated relevant documentation

Required

  • I accept to release these changes under the Apache 2.0 License

…ult to token always being wrong, which is misleading.
@Vafilor Vafilor added this to the v0.19.0 milestone Mar 12, 2021
@Vafilor Vafilor merged commit 88bd894 into onepanelio:master Mar 12, 2021
@Vafilor Vafilor deleted the feat/additional.login.errors branch March 12, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Indicate correct error for 5xx responses on logging in.
1 participant