feat: added support for azure blob storage #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushtehrani
reviewed
Jan 7, 2021
| @@ -21,6 +21,6 @@ spec: | |||
| - azure | |||
| envFrom: | |||
There was a problem hiding this comment.
I think it's better to set the env like this:
env:
- name: MINIO_ACCESS_KEY
valueFrom:
secretKeyRef:
name: onepanel
key: artifactRepositoryS3AccessKey
- name: MINIO_SECRET_KEY
valueFrom:
secretKeyRef:
name: onepanel
key: artifactRepositoryS3SecretKey
That way you don't have to do this
There was a problem hiding this comment.
@rushtehrani Ahh, good point. Much cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds support for azure blob storage
Which issue(s) this PR fixes:
Fixes onepanelio/core#
Special notes for your reviewer: