Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrum 46 add portfolio details for user in user service #42

Merged
merged 12 commits into from
Jul 31, 2024

Conversation

joewzy
Copy link
Collaborator

@joewzy joewzy commented Jul 29, 2024

Portfolio Entity

@joewzy joewzy self-assigned this Jul 29, 2024
Copy link
Collaborator

@djangbahevans djangbahevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for this behaviour

Josiah Kotey and others added 6 commits July 30, 2024 05:24
Refactor the User and Portfolio entities to improve code readability and maintainability.

- Added nullable constraint to the user_id foreign key in the Portfolio entity.
- Initialized the pendingDelete field in the User entity to false by default.
- Updated the cascade options for the portfolios field in the User entity.

Related to #SCRUM-46
@djangbahevans djangbahevans force-pushed the SCRUM-46-add-portfolio-details-for-user-in-user-service branch from 91da32e to 8338c9c Compare July 30, 2024 06:42
Update the DB_URL in the users-build.yml file to use localhost instead of the specific hostname "postgres". This change ensures that the database connection is established correctly.

Related to #SCRUM-46
djangbahevans and others added 5 commits July 30, 2024 12:46
Update the test logging configuration in the build.gradle.kts file to include "passed", "skipped", and "failed" events. This change improves the visibility of test results.

Related to #SCRUM-46
Refactor the UserTest class to improve code readability and maintainability. Removed unused imports and unnecessary comments. Updated test assertions for portfolio and user counts.

Related to #SCRUM-46
@joewzy joewzy merged commit 86b515a into main Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants