Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAT-1593] Fix missing webhook type and evidence folder webhook #138

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

miguelfteixeira
Copy link
Contributor

This pull request introduce the following changes:

  • Add workflow_timeline_file type to fix a bug parsing workflow_timeline_file.created webhooks using the client libraries;
  • Add support for the workflow_run_evidence_folder.created webhook.

The resource type was missing, we need it in order to parse
the webhook payload using the official client libraries.
Copy link
Contributor

@dvacca-onfido dvacca-onfido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, could you please just make the title more descriptive, as it's going to be published into release notes, and add perhaps the ticket number (if available)?

@miguelfteixeira miguelfteixeira changed the title Update webhooks [CAT-1593] Fix missing webhook type and evidence folder webhook Dec 19, 2024
@dvacca-onfido dvacca-onfido merged commit 9ab76fa into onfido:master Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants