[CAT-1120] Improve readme, fix id photos list and regex in tasks definition #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvacca-onfido
force-pushed
the
improve-readme-and-fix-id-photos-list
branch
from
4fb2bdc to
fcaf5e6
Compare
dvacca-onfido
requested review from
RiccardoPetteruti-Onfido,
DavidMealha-Onfido and
sofia-gomes-onfido
RiccardoPetteruti-Onfido
approved these changes
Jun 3, 2024
RiccardoPetteruti-Onfido
approved these changes
Jun 4, 2024
sofia-gomes-onfido
approved these changes
Jun 4, 2024
dvacca-onfido
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename schema returned by
list_id_photosoperation fromID Photos listintoId Photos listfor consistency as discussed in onfido/onfido-python#58 (comment).Taking also the opportunity for replacing hardcoded value for webhook verification token inside templated README.md files into a value retrieved from environment.
Lastly fixing also warning below raised when running ruby integration tests:
warning: character class has '-' without escape: /^[0-9a-z-_]+$/