Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int 1310 ruby onfleet fix tests #15

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

lisandrobigi-onfleet
Copy link
Contributor

@lisandrobigi-onfleet lisandrobigi-onfleet commented Jun 19, 2024

Describe the solution
Fixes for testing the Delivery Manifest API Endpoint. Also WebMock blocks HTTP requests in integration tests so WebMock.allow_net_connect! was added to test_onfleet.rb


Added

  • Configure google_api_key and query_parameters_hash as optional query parameters
  • Fix Delivery Manifest test
  • Added WebMock.allow_net_connect! to fix running tests error.

Changed

Deprecated

Removed

Fixed

Security

Copy link
Contributor

@danmenza danmenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved ✅

@lisandrobigi-onfleet lisandrobigi-onfleet merged commit 3865b6d into main Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants