Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create documentation for InclusiveRange #39

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Create documentation for InclusiveRange #39

merged 4 commits into from
Jan 16, 2024

Conversation

dsainati1
Copy link
Contributor

No description provided.

@dsainati1 dsainati1 added the documentation Improvements or additions to documentation label Jan 3, 2024
@dsainati1 dsainati1 self-assigned this Jan 3, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cadence-lang-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 6:38pm

@dsainati1
Copy link
Contributor Author

cc @darkdrag00nv2 please take a look at this and let me know how it looks

turbolent
turbolent approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This should only get merged once the feature branch got merged (https://github.com/onflow/cadence/tree/feature/range-type)

@dsainati1
Copy link
Contributor Author

Ah I didn't realize this wasn't merged in yet. What are we waiting on to merge the feature branch?

@SupunS
Copy link
Member

SupunS commented Jan 5, 2024

What are we waiting on to merge the feature branch?

It was on hold till all the subtasks were completed, and then until the stable-cadence was merged to master.
Now that both are done, I started syncing it to master - there's quite a bit of conflicts there. Will open a PR soon.

darkdrag00nv2
darkdrag00nv2 reviewed Jan 5, 2024
View reviewed changes
Copy link

@darkdrag00nv2 darkdrag00nv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we agreed that we should fix onflow/cadence#2886 before shipping the feature.

See: onflow/cadence#2886 (comment)

@dsainati1
Copy link
Contributor Author

@turbolent @SupunS now that the feature branch is merged this should be ready for review

@dsainati1 dsainati1 merged commit d21d4c0 into main Jan 16, 2024
2 checks passed
@dsainati1 dsainati1 deleted the sainati/inclusive-range-docs branch January 16, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdrag00nv2 darkdrag00nv2 darkdrag00nv2 left review comments

@turbolent turbolent turbolent approved these changes

@joshuahannan joshuahannan Awaiting requested review from joshuahannan

@SupunS SupunS Awaiting requested review from SupunS

@j1010001 j1010001 Awaiting requested review from j1010001

Assignees

@dsainati1 dsainati1

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsainati1 @SupunS @turbolent @darkdrag00nv2