Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy common contracts on EmulatorBackend's Blockchain #124

Merged
merged 2 commits into from
May 29, 2023

Conversation

m-Peter
Copy link
Contributor

@m-Peter m-Peter commented May 24, 2023

Work towards: onflow/developer-grants#148

Description

Uses the flow-emulator@v0.49.0 version to take advantage of the emulator.CommonContracts publicly exposed variable, and makes these contracts available on the Cadence testing framework (for integration tests). It also provides a base stdlib.Configuration, so that they can be easily imported with the new import scheme.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be very useful! 👏

Comment on lines +445 to +449
for contract, address := range configuration.Addresses {
// We do not want to override the base configuration,
// which includes the mapping for system/common contracts.
e.configuration.Addresses[contract] = address
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@m-Peter m-Peter force-pushed the common-deployed-contracts branch from 815d4d7 to 31034b1 Compare May 29, 2023 07:30
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label May 29, 2023
@turbolent turbolent merged commit 2dd0a84 into onflow:master May 29, 2023
@m-Peter m-Peter deleted the common-deployed-contracts branch June 5, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants