Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LS] Add FVM stdlib to Flow Integration #332

Merged
merged 8 commits into from
Aug 8, 2024
Merged

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Apr 3, 2024

Closes #331

Description

Adds option to LS to accept additional stdlib values. This option is used by flow integration to provide FVM-native stdlib values (e.g. InternalEVM contract right now... others in future?)


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink changed the title [LS] Add FVM stdlib to Flow Integration (WIP) [LS] Add FVM stdlib to Flow Integration Apr 3, 2024
@jribbink jribbink marked this pull request as ready for review April 3, 2024 20:30
@jribbink jribbink marked this pull request as draft April 3, 2024 20:30
@jribbink
Copy link
Contributor Author

jribbink commented Apr 3, 2024

I wasn't able to add the InternalEVM Contract to the WASM build unfortunately. Various downstream dependencies from the InternalEVM value declaration in flow-go (related to go-ethereum) do not build in WASM due to x/sys dependency, so it wasn't possible to import the FVM stdlib to the WASM build as a result.

I think this probably means that certain refactoring needs to be done in flow-go in order to avoid these dependencies... but not really sure how easy this is.

@jribbink jribbink marked this pull request as ready for review April 3, 2024 20:50
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

languageserver/test/index.test.ts Show resolved Hide resolved
@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label Apr 10, 2024
@turbolent turbolent merged commit 18e6ea2 into master Aug 8, 2024
10 checks passed
@turbolent turbolent deleted the jribbink/ls-internal-evm branch August 8, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LS] Add InternalEVM stdlib Contract
3 participants