Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LS] Add Crypto identifier import back #444

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Oct 24, 2024

Closes #443

Description

Restores Crypto identifier import in LS

Caveat: It won't be available in WASM build. Unfortunately, as far as I remember flow-go (or one of its dependencies) has errors compiling to WASM. We now rely on stdlib.CryptoContractLocation from flow-go, so this is a bit of a blocker ATM (We could just hardcode the "Crypto" string because that's all this constant is, but it doesn't totally feel right to do so).


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turbolent
Copy link
Member

Thanks! stdlib is actually Cadence's stdlib, so this might be not an issue. However, good point about using flow-go in WebAssembly builds being an issue, we'll also need to resolve that

@jribbink
Copy link
Contributor Author

Thanks! stdlib is actually Cadence's stdlib, so this might be not an issue. However, good point about using flow-go in WebAssembly builds being an issue, we'll also need to resolve that

Oh, oops 😅 , I thought I imported that from flow-go. But yeah, the WASM issue exists for InternalEVM currently. I'll update the WASM build to include the Crypto contract then...

@jribbink jribbink requested a review from turbolent October 24, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LS] import Crypto no longer available
2 participants