Improve test case

onflow · Jul 19, 2023 · 4d42e5f · 4d42e5f
1 parent 3960890
commit 4d42e5f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/runtime/interpreter/value.go b/runtime/interpreter/value.go
@@ -2927,12 +2927,12 @@ func (v *ArrayValue) Reverse(
 		common.ZeroAddress,
 		uint64(count),
 		func() Value {
-			if idx < 0 {
+			if index < 0 {
 				return nil
 			}
 
-			value := v.Get(interpreter, locationRange, idx)
-			idx--
+			value := v.Get(interpreter, locationRange, index)
+			index--
 
 			return value.Transfer(
 				interpreter,

diff --git a/runtime/sema/type.go b/runtime/sema/type.go
@@ -2225,7 +2225,7 @@ func ArraySliceFunctionType(elementType Type) *FunctionType {
 	}
 }
 
-func ArrayReverseFunctionType(arrayType sema.ArrayType) *FunctionType {
+func ArrayReverseFunctionType(arrayType ArrayType) *FunctionType {
 	return &FunctionType{
 		Parameters:           []Parameter{},
 		ReturnTypeAnnotation: NewTypeAnnotation(arrayType),

diff --git a/runtime/tests/checker/arrays_dictionaries_test.go b/runtime/tests/checker/arrays_dictionaries_test.go
@@ -1117,14 +1117,15 @@ func TestCheckResourceArrayReverseInvalid(t *testing.T) {
 
 		fun test(): @[X] {
 			let xs <- [<-create X()]
-			return <-xs.reverse()
+			let revxs <-xs.reverse()
+			destroy xs
+			return <- revxs
 		}
     `)
 
-	errs := RequireCheckerErrors(t, err, 2)
+	errs := RequireCheckerErrors(t, err, 1)
 
 	assert.IsType(t, &sema.InvalidResourceArrayMemberError{}, errs[0])
-	assert.IsType(t, &sema.ResourceLossError{}, errs[1])
 }
 
 func TestCheckArrayContains(t *testing.T) {