Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parser from using panics to error return values #1650

Closed
turbolent opened this issue May 13, 2022 · 0 comments · Fixed by #1764
Closed

Refactor parser from using panics to error return values #1650

turbolent opened this issue May 13, 2022 · 0 comments · Fixed by #1764
Assignees
@SupunS
Labels
Technical Debt

Comments

@turbolent
Copy link
Member

Context

The parser is currently using panics to abort parsing when an unrecoverable parse error is encountered.

Definition of Done

Replace panics with an explicit error return value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SupunS SupunS

Labels
Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor parser to always return syntax errors onflow/cadence
2 participants
@turbolent @SupunS