Refactor parser to always return syntax errors

[SupunS]

Closes #1650

Description

Depends on #1718 and #1746

---

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[codecov]

Codecov Report

Merging #1764 (3f08026) into master (6eaed7e) will decrease coverage by 0.33%.
The diff coverage is 63.86%.

@@            Coverage Diff             @@
##           master    #1764      +/-   ##
==========================================
- Coverage   77.37%   77.04%   -0.34%     
==========================================
  Files         305      305              
  Lines       62677    63043     +366     
==========================================
+ Hits        48498    48569      +71     
- Misses      12558    12757     +199     
- Partials     1621     1717      +96     

Flag	Coverage Δ
unittests	77.04% <63.86%> (-0.34%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
runtime/parser/transaction.go	68.30% <32.69%> (-14.31%)	⬇️
runtime/parser/function.go	67.41% <45.00%> (-3.41%)	⬇️
runtime/parser/statement.go	80.20% <53.43%> (-13.16%)	⬇️
runtime/parser/declaration.go	84.61% <64.02%> (-4.76%)	⬇️
runtime/parser/type.go	84.07% <68.45%> (-5.00%)	⬇️
runtime/parser/expression.go	87.83% <70.07%> (-4.83%)	⬇️
runtime/parser/parser.go	89.09% <100.00%> (-0.76%)	⬇️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eaed7e...3f08026. Read the comment docs.

[github-actions]

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 6d1ce5a
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
CheckContractInterfaceFungibleTokenConformance-2	204µs ± 8%	204µs ± 6%	~	(p=0.620 n=7+7)
ContractInterfaceFungibleToken-2	58.5µs ± 8%	57.5µs ±10%	~	(p=0.318 n=7+7)
InterpretRecursionFib-2	5.75ms ± 7%	5.72ms ± 7%	~	(p=0.902 n=7+7)
NewInterpreter/new_interpreter-2	1.48µs ± 2%	1.49µs ± 2%	~	(p=0.628 n=6+7)
NewInterpreter/new_sub-interpreter-2	3.07µs ± 3%	3.05µs ± 2%	~	(p=0.366 n=7+6)
ParseArray-2	11.1ms ± 2%	11.0ms ± 2%	~	(p=0.240 n=6+6)
ParseDeploy/byte_array-2	16.8ms ± 2%	16.6ms ± 1%	−1.58%	(p=0.041 n=6+6)
ParseDeploy/decode_hex-2	1.58ms ± 4%	1.55ms ± 2%	~	(p=0.101 n=7+6)
ParseFungibleToken/With_memory_metering-2	279µs ± 2%	282µs ± 5%	~	(p=0.366 n=6+7)
ParseFungibleToken/Without_memory_metering-2	212µs ± 6%	211µs ± 4%	~	(p=0.902 n=7+7)
ParseInfix-2	9.76µs ± 3%	9.76µs ± 2%	~	(p=0.731 n=7+6)
QualifiedIdentifierCreation/One_level-2	3.63ns ± 2%	3.63ns ± 3%	~	(p=0.902 n=7+7)
QualifiedIdentifierCreation/Three_levels-2	192ns ± 1%	194ns ± 2%	~	(p=0.165 n=7+7)
RuntimeFungibleTokenTransfer-2	1.32ms ± 2%	1.44ms ±23%	~	(p=0.366 n=6+7)
RuntimeResourceDictionaryValues-2	7.99ms ± 1%	8.11ms ± 3%	~	(p=0.181 n=6+7)
ValueIsSubtypeOfSemaType-2	117ns ± 1%	119ns ± 3%	~	(p=0.218 n=6+7)
	alloc/op		delta
CheckContractInterfaceFungibleTokenConformance-2	67.0kB ± 0%	67.0kB ± 0%	~	(p=0.462 n=7+7)
ContractInterfaceFungibleToken-2	26.8kB ± 0%	26.8kB ± 0%	~	(all equal)
InterpretRecursionFib-2	1.51MB ± 0%	1.51MB ± 0%	~	(p=0.147 n=7+7)
NewInterpreter/new_interpreter-2	928B ± 0%	928B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	1.46kB ± 0%	1.46kB ± 0%	~	(all equal)
ParseArray-2	2.82MB ± 2%	2.79MB ± 3%	~	(p=0.209 n=7+7)
ParseDeploy/byte_array-2	4.44MB ± 3%	4.44MB ± 3%	~	(p=0.620 n=7+7)
ParseDeploy/decode_hex-2	214kB ± 0%	214kB ± 0%	~	(p=0.082 n=6+7)
ParseFungibleToken/With_memory_metering-2	36.3kB ± 0%	36.3kB ± 0%	~	(p=0.633 n=7+7)
ParseFungibleToken/Without_memory_metering-2	36.3kB ± 0%	36.3kB ± 0%	~	(p=0.232 n=7+7)
ParseInfix-2	2.17kB ± 0%	2.17kB ± 0%	~	(p=1.000 n=7+7)
QualifiedIdentifierCreation/One_level-2	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	64.0B ± 0%	64.0B ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-2	232kB ± 0%	232kB ± 0%	~	(p=0.875 n=7+7)
RuntimeResourceDictionaryValues-2	2.25MB ± 0%	2.25MB ± 0%	~	(p=0.366 n=7+6)
ValueIsSubtypeOfSemaType-2	48.0B ± 0%	48.0B ± 0%	~	(all equal)
	allocs/op		delta
CheckContractInterfaceFungibleTokenConformance-2	1.08k ± 0%	1.08k ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	461 ± 0%	461 ± 0%	~	(all equal)
InterpretRecursionFib-2	33.5k ± 0%	33.5k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-2	13.0 ± 0%	13.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	42.0 ± 0%	42.0 ± 0%	~	(all equal)
ParseArray-2	70.0k ± 0%	70.0k ± 0%	~	(p=1.000 n=7+7)
ParseDeploy/byte_array-2	105k ± 0%	105k ± 0%	~	(p=1.000 n=7+7)
ParseDeploy/decode_hex-2	77.0 ± 0%	77.0 ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-2	1.06k ± 0%	1.06k ± 0%	~	(all equal)
ParseFungibleToken/Without_memory_metering-2	1.06k ± 0%	1.06k ± 0%	~	(all equal)
ParseInfix-2	66.0 ± 0%	66.0 ± 0%	~	(all equal)
QualifiedIdentifierCreation/One_level-2	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	2.00 ± 0%	2.00 ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-2	4.19k ± 0%	4.19k ± 0%	~	(p=0.678 n=6+7)
RuntimeResourceDictionaryValues-2	37.5k ± 0%	37.5k ± 0%	~	(p=0.580 n=6+7)
ValueIsSubtypeOfSemaType-2	1.00 ± 0%	1.00 ± 0%	~	(all equal)

[turbolent]

Great work!

[turbolent]

Great work! 👍