Implement check functionality in AuthAccount
#2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2492 +/- ##
=======================================
Coverage 78.45% 78.46%
=======================================
Files 336 336
Lines 76561 76606 +45
=======================================
+ Hits 60068 60109 +41
- Misses 14262 14264 +2
- Partials 2231 2233 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
darkdrag00nv2
force-pushed
the
check_authaccount_564
branch
from
a6b7c4f to
235e9db
Compare
darkdrag00nv2
requested review from
turbolent,
SupunS,
dsainati1 and
joshuahannan
as code owners
|
This is ready for review now! |
turbolent
reviewed
May 10, 2023
dsainati1
approved these changes
May 15, 2023
SupunS
reviewed
May 15, 2023
turbolent
approved these changes
May 16, 2023
|
@turbolent @dsainati1 @SupunS Ready for review now. Have updated the signature as per discussion. |
darkdrag00nv2
force-pushed
the
check_authaccount_564
branch
from
53f9118 to
017b4bb
Compare
|
Force push after resolving merge conflicts. |
|
@SupunS Could you please have a last look? |
SupunS
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #564
Work towards onflow/developer-grants#179
Description
Adds
AuthAccount.check(storagePath)function to check if the type parameters can be used to create a reference for the object stored in the storage path.TODO:
masterbranchFiles changedin the Github PR explorer