Remove pub, priv and pub(set) access modifiers
#2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsainati1
commented
Jun 6, 2023
turbolent
added
the
Language Breaking Change
Base automatically changed from
sainati/attachment-iteration
to
feature/entitlements
June 9, 2023 22:24
…low/cadence into sainati/remove-pub-priv
dsainati1
changed the base branch from
feature/entitlements
to
sainati/capability-upcast-conversion
dsainati1
commented
Jun 14, 2023
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/stable-cadence commit 115c6c4 Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## feature/stable-cadence #2540 +/- ##
==========================================================
+ Coverage 78.46% 78.84% +0.38%
==========================================================
Files 326 340 +14
Lines 73424 80309 +6885
==========================================================
+ Hits 57611 63321 +5710
- Misses 13714 14689 +975
- Partials 2099 2299 +200
Flags with carried forward coverage won't be shown. Click here to find out more.
|
turbolent
reviewed
Jun 21, 2023
turbolent
approved these changes
Jun 21, 2023
Base automatically changed from
sainati/capability-upcast-conversion
to
feature/entitlements
June 21, 2023 21:40
SupunS
approved these changes
Jun 21, 2023
|
@dsainati1 Probably want to target |
dsainati1
changed the base branch from
feature/entitlements
to
feature/stable-cadence
auto-merge was automatically disabled
June 22, 2023 01:49
Pull request was closed
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2640
Implementation of onflow/flips#84
This removes support for the
pub,privandpub(set)access modifiers from the language.pubis equivalent toaccess(all), which should be used insteadprivis equivalent toaccess(self)which should be used insteadpub(set)has no equivalent in Cadence. If globally accessible mutation is desirable, declare anaccess(all)setter function for that fieldThis PR is mostly test updates; the actual parser code changes are very small.
masterbranchFiles changedin the Github PR explorer