Introduce built-in mutability entitlements #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
dsainati1
reviewed
Jun 21, 2023
turbolent
approved these changes
Jun 21, 2023
|
We can probably merge this once the FLIP is approved, even if the names are still going to potentially get adjusted later |
6 tasks
SupunS
force-pushed
the
supun/member-access-semantics
branch
from
9a64a7f to
7cfcc05
Compare
Base automatically changed from
supun/member-access-semantics
to
feature/mutability-restrictions
July 6, 2023 16:42
…onflow/cadence into supun/builtin-entitlements
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/mutability-restrictions commit 2a08798 Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## feature/mutability-restrictions #2586 +/- ##
===================================================================
- Coverage 78.96% 78.90% -0.06%
===================================================================
Files 340 341 +1
Lines 81724 81842 +118
===================================================================
+ Hits 64534 64581 +47
- Misses 14834 14904 +70
- Partials 2356 2357 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #2638
Work towards onflow/flips#86
Description
Introduces three built-in mutability-related entitlements:
InsertableRemovableMutableNote: This PR only introduces these entitlements. Array/dictionary functions still don't use them. That will be added in a follow-up PR.
masterbranchFiles changedin the Github PR explorer