Prevent recursive transfers (internal #133)

runtime/interpreter/errors.go

@@ -975,3 +975,16 @@ func (AccountLinkingForbiddenError) IsUserError() {}
 func (e AccountLinkingForbiddenError) Error() string {
 	return "account linking is not allowed"
 }
+
+// RecursiveTransferError
+type RecursiveTransferError struct {
+	LocationRange
+}
+
+var _ errors.UserError = RecursiveTransferError{}
+
+func (RecursiveTransferError) IsUserError() {}
+
+func (RecursiveTransferError) Error() string {
+	return "recursive transfer of value"
+}

runtime/interpreter/interpreter.go

@@ -1692,6 +1692,7 @@ func (interpreter *Interpreter) transferAndConvert(
 		atree.Address{},
 		false,
 		nil,
+		nil,
 	)
 
 	result := interpreter.ConvertAndBox(
@@ -3865,6 +3866,7 @@ func (interpreter *Interpreter) authAccountSaveFunction(addressValue AddressValu
 				atree.Address(address),
 				true,
 				nil,
+				nil,
 			)
 
 			// Write new value
@@ -3988,6 +3990,7 @@ func (interpreter *Interpreter) authAccountReadFunction(addressValue AddressValu
 				atree.Address{},
 				false,
 				nil,
+				nil,
 			)
 
 			// Remove the value from storage,

runtime/interpreter/interpreter_expression.go

@@ -1331,6 +1331,7 @@ func (interpreter *Interpreter) VisitAttachExpression(attachExpression *ast.Atta
 		atree.Address{},
 		false,
 		nil,
+		nil,
 	).(*CompositeValue)
 
 	// we enforce this in the checker

runtime/interpreter/interpreter_invocation.go

@@ -100,6 +100,7 @@ func (interpreter *Interpreter) invokeFunctionValue(
 					atree.Address{},
 					false,
 					nil,
+					nil,
 				)
 			}
 		}

runtime/interpreter/interpreter_statement.go

@@ -323,6 +323,7 @@ func (interpreter *Interpreter) VisitForStatement(statement *ast.ForStatement) S
 		atree.Address{},
 		false,
 		nil,
+		nil,
 	)
 
 	iterable, ok := transferredValue.(IterableValue)

runtime/interpreter/simplecompositevalue.go

@@ -236,6 +236,7 @@ func (v *SimpleCompositeValue) Transfer(
 	_ atree.Address,
 	remove bool,
 	storable atree.Storable,
+	_ map[atree.StorageID]struct{},
 ) Value {
 	// TODO: actually not needed, value is not storable
 	if remove {