Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to parsed array and dictionary literals #2924

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

bluesign
Copy link
Contributor

@bluesign bluesign commented Nov 2, 2023

Description

I am not 100% it is correct approach, but I tried to fix literal parsing for dictionary and arrays. ( which was causing issues on flow-cli onflow/flow-cli#1254 )


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (323b887) 79.43% compared to head (1723e1e) 79.42%.
Report is 5 commits behind head on master.

❗ Current head 1723e1e differs from pull request most recent head 9088121. Consider uploading reports for the commit 9088121 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2924      +/-   ##
==========================================
- Coverage   79.43%   79.42%   -0.01%     
==========================================
  Files         332      332              
  Lines       79111    79134      +23     
==========================================
+ Hits        62842    62853      +11     
- Misses      13958    13966       +8     
- Partials     2311     2315       +4     
Flag Coverage Δ
unittests 79.42% <55.55%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
runtime/literal.go 84.08% <55.55%> (-3.14%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent self-assigned this Nov 6, 2023
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good idea to add the types now 👍

runtime/literal.go Outdated Show resolved Hide resolved
runtime/literal.go Outdated Show resolved Hide resolved
runtime/literal.go Outdated Show resolved Hide resolved
@turbolent turbolent changed the title Fix literal parsing for Arrays and Dictionaries Add types to parsed array and dictionary literals Nov 6, 2023
Co-authored-by: Bastian Müller <bastian@turbolent.com>
@turbolent turbolent merged commit 008d2df into onflow:master Nov 8, 2023
8 of 12 checks passed
@bluesign
Copy link
Contributor Author

bluesign commented Nov 8, 2023

sorry @turbolent I missed the PR comments, thanks for fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants