Port bug fixes from `v0.42.5-patch.1` #2955

SupunS · 2023-11-29T23:36:10Z

Description

Includes:

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

Co-authored-by: Bastian Müller <bastian@turbolent.com>

[v0.42] Prevent nested contract deployments

…ve existing writes

Sync with public `v0.42`

…ication Fix nested resource moves

prevent setting members during destruction

Reject nested resource moves with second transfer during destruction

…v0.42-public

… twice

Evaluate getters and setters for second value transfers once rather than twice

Syncing to the `v0.42` of the public-repo

the second value needs to be evaluated *before* declaring the new variable, as the second value might refer to a shadowed variable of the same name

Reject resources-methods being used as function-pointers

…eclaration-evaluation

Transfer value before the second value is visited

…nvalidation

Reject resource method pointers in assignment

github-actions · 2023-11-29T23:42:04Z

Cadence Benchstat comparison

This branch with compared with the base branch onflow:v0.42 commit e75c940
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
CheckContractInterfaceFungibleTokenConformance-4	84.2µs ± 0%	83.1µs ± 0%	~	(p=1.000 n=1+1)
ContractInterfaceFungibleToken-4	26.9µs ± 0%	27.0µs ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsCCF-4	114ms ± 0%	112ms ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	375ms ± 0%	370ms ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	2.46µs ± 0%	2.40µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.TokensWithdrawn-4	1.93µs ± 0%	1.91µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	2.47µs ± 0%	2.47µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	2.55µs ± 0%	2.58µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.95µs ± 0%	1.95µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	2.26µs ± 0%	2.25µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited-4	2.29µs ± 0%	2.32µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	2.27µs ± 0%	2.26µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensMinted-4	1.93µs ± 0%	1.90µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensWithdrawn-4	2.34µs ± 0%	2.30µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowFees.FeesDeducted-4	9.21µs ± 0%	9.15µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowFees.TokensWithdrawn-4	5.44µs ± 0%	5.35µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	8.30µs ± 0%	8.25µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	11.6µs ± 0%	11.3µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	5.50µs ± 0%	5.48µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	7.02µs ± 0%	7.16µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited-4	7.53µs ± 0%	7.82µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	6.72µs ± 0%	6.68µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensMinted-4	5.51µs ± 0%	5.45µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensWithdrawn-4	7.55µs ± 0%	7.36µs ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsCCF-4	59.3ms ± 0%	57.5ms ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	102ms ± 0%	100ms ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	1.26µs ± 0%	1.20µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-4	1.01µs ± 0%	0.99µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.24µs ± 0%	1.21µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.38µs ± 0%	1.31µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.02µs ± 0%	1.02µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	1.15µs ± 0%	1.15µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-4	1.22µs ± 0%	1.19µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.20µs ± 0%	1.18µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-4	1.02µs ± 0%	1.01µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-4	1.23µs ± 0%	1.19µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-4	2.38µs ± 0%	2.34µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-4	1.28µs ± 0%	1.27µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	2.09µs ± 0%	2.06µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	3.01µs ± 0%	2.95µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	1.31µs ± 0%	1.30µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	1.70µs ± 0%	1.76µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-4	1.98µs ± 0%	2.01µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	1.58µs ± 0%	1.56µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-4	1.29µs ± 0%	1.30µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-4	1.97µs ± 0%	1.96µs ± 0%	~	(p=1.000 n=1+1)
ExportType/composite_type-4	219ns ± 0%	217ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	68.0ns ± 0%	63.8ns ± 0%	~	(p=1.000 n=1+1)
InterpretRecursionFib-4	1.86ms ± 0%	1.83ms ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	924ns ± 0%	914ns ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	447ns ± 0%	458ns ± 0%	~	(p=1.000 n=1+1)
ParseArray-4	6.14ms ± 0%	5.97ms ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/byte_array-4	9.16ms ± 0%	9.17ms ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/decode_hex-4	944µs ± 0%	945µs ± 0%	~	(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-4	141µs ± 0%	139µs ± 0%	~	(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-4	110µs ± 0%	110µs ± 0%	~	(p=1.000 n=1+1)
ParseInfix-4	5.29µs ± 0%	5.21µs ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-4	2.14ns ± 0%	2.43ns ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-4	83.1ns ± 0%	81.7ns ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	3.94ms ± 0%	3.95ms ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	3.46µs ± 0%	3.46µs ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/arrays-4	232ns ± 0%	226ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/composites-4	85.8ns ± 0%	88.3ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/integers-4	125ns ± 0%	129ns ± 0%	~	(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-4	73.6ns ± 0%	67.8ns ± 0%	~	(p=1.000 n=1+1)

	alloc/op		delta
CheckContractInterfaceFungibleTokenConformance-4	49.2kB ± 0%	49.3kB ± 0%	~	(p=1.000 n=1+1)
ContractInterfaceFungibleToken-4	23.4kB ± 0%	23.4kB ± 0%	~	(all equal)
DecodeBatchEventsCCF-4	67.4MB ± 0%	67.4MB ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	246MB ± 0%	246MB ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	1.41kB ± 0%	1.41kB ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	1.22kB ± 0%	1.22kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.49kB ± 0%	1.49kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.50kB ± 0%	1.50kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.26kB ± 0%	1.26kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	1.38kB ± 0%	1.38kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	1.34kB ± 0%	1.34kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.33kB ± 0%	1.33kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	1.22kB ± 0%	1.22kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	1.35kB ± 0%	1.35kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	6.02kB ± 0%	6.02kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	3.62kB ± 0%	3.62kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	5.45kB ± 0%	5.45kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	7.37kB ± 0%	7.37kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	3.66kB ± 0%	3.66kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	4.55kB ± 0%	4.55kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	4.91kB ± 0%	4.91kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	4.49kB ± 0%	4.49kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	3.62kB ± 0%	3.62kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	4.91kB ± 0%	4.91kB ± 0%	~	(all equal)
EncodeBatchEventsCCF-4	37.1MB ± 0%	37.1MB ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	34.0MB ± 0%	34.0MB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	736B ± 0%	736B ± 0%	~	(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-4	688B ± 0%	688B ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	800B ± 0%	800B ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	768B ± 0%	768B ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	704B ± 0%	704B ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	784B ± 0%	784B ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited-4	752B ± 0%	752B ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	736B ± 0%	736B ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensMinted-4	688B ± 0%	688B ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-4	752B ± 0%	752B ± 0%	~	(all equal)
EncodeJSON/FlowFees.FeesDeducted-4	768B ± 0%	768B ± 0%	~	(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4	408B ± 0%	408B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	760B ± 0%	760B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	952B ± 0%	952B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	424B ± 0%	424B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	624B ± 0%	624B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited-4	680B ± 0%	680B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	544B ± 0%	544B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensMinted-4	416B ± 0%	416B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4	672B ± 0%	672B ± 0%	~	(all equal)
ExportType/composite_type-4	136B ± 0%	136B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
InterpretRecursionFib-4	1.00MB ± 0%	1.00MB ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	976B ± 0%	976B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	200B ± 0%	200B ± 0%	~	(all equal)
ParseArray-4	2.71MB ± 0%	2.71MB ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/byte_array-4	4.22MB ± 0%	4.22MB ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/decode_hex-4	214kB ± 0%	214kB ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-4	28.9kB ± 0%	28.9kB ± 0%	~	(all equal)
ParseFungibleToken/Without_memory_metering-4	28.9kB ± 0%	28.9kB ± 0%	~	(all equal)
ParseInfix-4	1.92kB ± 0%	1.92kB ± 0%	~	(all equal)
QualifiedIdentifierCreation/One_level-4	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	64.0B ± 0%	64.0B ± 0%	~	(all equal)
RuntimeResourceDictionaryValues-4	2.30MB ± 0%	2.29MB ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	3.02kB ± 0%	3.02kB ± 0%	~	(all equal)
SuperTypeInference/arrays-4	96.0B ± 0%	96.0B ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00B	0.00B	~	(all equal)
SuperTypeInference/integers-4	0.00B	0.00B	~	(all equal)
ValueIsSubtypeOfSemaType-4	48.0B ± 0%	48.0B ± 0%	~	(all equal)

	allocs/op		delta
CheckContractInterfaceFungibleTokenConformance-4	811 ± 0%	811 ± 0%	~	(all equal)
ContractInterfaceFungibleToken-4	370 ± 0%	370 ± 0%	~	(all equal)
DecodeBatchEventsCCF-4	1.48M ± 0%	1.48M ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	4.70M ± 0%	4.70M ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	32.0 ± 0%	32.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	126 ± 0%	126 ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	71.0 ± 0%	71.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	102 ± 0%	102 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	159 ± 0%	159 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	70.0 ± 0%	70.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	87.0 ± 0%	87.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	95.0 ± 0%	95.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	86.0 ± 0%	86.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	71.0 ± 0%	71.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	95.0 ± 0%	95.0 ± 0%	~	(all equal)
EncodeBatchEventsCCF-4	467k ± 0%	467k ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	757k ± 0%	757k ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	9.00 ± 0%	9.00 ± 0%	~	(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-4	9.00 ± 0%	9.00 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	9.00 ± 0%	9.00 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	9.00 ± 0%	9.00 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	9.00 ± 0%	9.00 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	9.00 ± 0%	9.00 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited-4	10.0 ± 0%	10.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	10.0 ± 0%	10.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensMinted-4	9.00 ± 0%	9.00 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-4	10.0 ± 0%	10.0 ± 0%	~	(all equal)
EncodeJSON/FlowFees.FeesDeducted-4	17.0 ± 0%	17.0 ± 0%	~	(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4	10.0 ± 0%	10.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	14.0 ± 0%	14.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	23.0 ± 0%	23.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	10.0 ± 0%	10.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited-4	17.0 ± 0%	17.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	12.0 ± 0%	12.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensMinted-4	11.0 ± 0%	11.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4	16.0 ± 0%	16.0 ± 0%	~	(all equal)
ExportType/composite_type-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
InterpretRecursionFib-4	18.9k ± 0%	18.9k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-4	16.0 ± 0%	16.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
ParseArray-4	59.6k ± 0%	59.6k ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/byte_array-4	89.4k ± 0%	89.4k ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/decode_hex-4	63.0 ± 0%	63.0 ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-4	768 ± 0%	768 ± 0%	~	(all equal)
ParseFungibleToken/Without_memory_metering-4	768 ± 0%	768 ± 0%	~	(all equal)
ParseInfix-4	48.0 ± 0%	48.0 ± 0%	~	(all equal)
QualifiedIdentifierCreation/One_level-4	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	2.00 ± 0%	2.00 ± 0%	~	(all equal)
RuntimeResourceDictionaryValues-4	37.0k ± 0%	37.0k ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	50.0 ± 0%	50.0 ± 0%	~	(all equal)
SuperTypeInference/arrays-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00	0.00	~	(all equal)
SuperTypeInference/integers-4	0.00	0.00	~	(all equal)
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)

codecov · 2023-11-29T23:45:38Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e75c940) 79.44% compared to head (6524cd9) 79.48%.

Files	Patch %	Lines
runtime/ast/conditionkind.go	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            v0.42    #2955      +/-   ##
==========================================
+ Coverage   79.44%   79.48%   +0.03%     
==========================================
  Files         334      334              
  Lines       79067    79079      +12     
==========================================
+ Hits        62816    62853      +37     
+ Misses      13942    13918      -24     
+ Partials     2309     2308       -1

Flag	Coverage Δ
unittests	`79.48% <98.90%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SupunS and others added 30 commits October 24, 2023 10:51

Prevent nested contract deployments

df4b6fd

Separate nested update vs sequential update tracking

03f1b91

Refactor code

a9a65d7

Co-authored-by: Bastian Müller <bastian@turbolent.com>

Merge pull request #148 from dapperlabs/supun/port-147

ba93bb3

[v0.42] Prevent nested contract deployments

commit storage temporarily before creating account, so host can obser…

4f95580

…ve existing writes

Merge pull request #149 from dapperlabs/bastian/fix-authaccount-creation

1ba2d97

rename the generator interface to RandomGenerator

76d9e9d

add new standard library value for revertibleRandom

ba84056

add revertibleRandom test

81dca7e

fix indent

fa40f27

update computation constant name from revertible to unsafe

275f3a1

add deprecation warning to doc string

9066751

Improve docstring, use "deprecated" keyword

5f76259

v0.42.3

c2db138

Merge pull request #150 from dapperlabs/supun/sync-with-public-v0.42

9be067b

Sync with public `v0.42`

Fix nested resource moves

f9b6fea

Add interpreter test

a7c9557

Merge pull request #151 from dapperlabs/supun/v0.42-fix-resource-dupl…

e08e4aa

…ication Fix nested resource moves

prevent setting members during destruction

cd9f8c9

Merge pull request #152 from dapperlabs/sainati/set-member-in-destructor

c868671

prevent setting members during destruction

Reject nested resource moves with second transfer during destruction

06c1c09

Merge pull request #153 from dapperlabs/supun/fix-nested-resource-move

4dd899c

Reject nested resource moves with second transfer during destruction

Merge branch 'v0.42' of https://github.com/onflow/cadence into supun/…

f4f2243

…v0.42-public

evaluate getter/setter once for second value declarations rather than…

57d4c3b

… twice

Merge pull request #155 from dapperlabs/sainati/second-value-transfer

c6df324

Evaluate getters and setters for second value transfers once rather than twice

Merge pull request #154 from dapperlabs/supun/v0.42-public

521d895

Syncing to the `v0.42` of the public-repo

reject resource invalidation in abstract type function conditions

e3c49d4

bring back test, ignore checker error

771c6ae

allow temporary move invalidations

a26ade0

fix evaluation order: declare new variable at the end, just like checker

b0bcad1

the second value needs to be evaluated *before* declaring the new variable, as the second value might refer to a shadowed variable of the same name

turbolent and others added 18 commits November 20, 2023 13:24

remove duplicate test

7720c38

Merge branch 'v0.42' into bastian/add-test

254f018

lint

692e4c4

Merge pull request #162 from dapperlabs/bastian/add-test

30c48c6

Reject bound function closures to resources

7caf7e7

Add more tests

fed2b8a

Transfer value before the second value is visited

7d09e47

Merge pull request #164 from dapperlabs/supun/bound-functions

0563403

Reject resources-methods being used as function-pointers

use visitVariableDeclaration in visitIfStatementWithVariableDeclaration

9a729c7

invalidate resource after failable casting

c069779

adjust location

cf33275

Merge pull request #166 from dapperlabs/bastian/improve-if-variable-d…

3151d8b

…eclaration-evaluation

Merge branch 'v0.42' into supun/fix-transfer

6be2863

Merge pull request #165 from dapperlabs/supun/fix-transfer

25ee29b

Transfer value before the second value is visited

add test for invalid resoruce use in else branch after second value i…

27297e1

…nvalidation

Merge pull request #167 from dapperlabs/bastian/add-test-2

a2f4f34

Reject resource method pointers in assignment

f9f4e6d

Merge pull request #179 from dapperlabs/supun/resource-method-poointers

6524cd9

Reject resource method pointers in assignment

SupunS added the Bugfix label Nov 29, 2023

SupunS self-assigned this Nov 29, 2023

SupunS requested review from turbolent and dsainati1 as code owners November 29, 2023 23:36

dsainati1 approved these changes Nov 29, 2023

View reviewed changes

turbolent approved these changes Nov 30, 2023

View reviewed changes

SupunS merged commit cdae59a into v0.42 Nov 30, 2023
12 of 14 checks passed

SupunS mentioned this pull request Nov 30, 2023

Port bug fixes from v0.42.5-patch.1 #2956

Merged

6 tasks

SupunS deleted the supun/internal-v0.42 branch November 30, 2023 16:42

BrewTestBot mentioned this pull request Nov 30, 2023

cadence 0.42.6 Homebrew/homebrew-core#156026

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port bug fixes from `v0.42.5-patch.1` #2955

Port bug fixes from `v0.42.5-patch.1` #2955

SupunS commented Nov 29, 2023

github-actions bot commented Nov 29, 2023

codecov bot commented Nov 29, 2023

Port bug fixes from v0.42.5-patch.1 #2955

Port bug fixes from v0.42.5-patch.1 #2955

Conversation

SupunS commented Nov 29, 2023

Description

github-actions bot commented Nov 29, 2023

Cadence Benchstat comparison

codecov bot commented Nov 29, 2023

Codecov Report

Port bug fixes from `v0.42.5-patch.1` #2955

Port bug fixes from `v0.42.5-patch.1` #2955