Code

Merge range type feature#3009

Code

Merged

turbolent merged 133 commits intomasteronflow/cadence:masterfrom feature/range-typeonflow/cadence:feature/range-typeCopy head branch name to clipboardJan 11, 2024

+5,937-357

Commits

Commits on Aug 25, 2023

• Merge pull request #2747 from onflow/supun/sync-range-type

  Show description for 4e0c932
  SupunS

  authored
  4e0c932

  Copy full SHA for 4e0c932

Commits on Aug 27, 2023

• Introduce InclusiveRange

  darkdrag00nv2

  committed
  ec147bd

  Copy full SHA for ec147bd

• Validate that the step is always non-zero

  darkdrag00nv2

  committed
  9517f7e

  Copy full SHA for 9517f7e

• Validate that step takes the direction of sequence towards end

  darkdrag00nv2

  committed
  f48199c

  Copy full SHA for f48199c

• More tests

  darkdrag00nv2

  committed
  d13a39c

  Copy full SHA for d13a39c

• Add invalid case tests in checker

  darkdrag00nv2

  committed
  258e541

  Copy full SHA for 258e541

• Add interpreter test cases

  darkdrag00nv2

  committed
  4fbe486

  Copy full SHA for 4fbe486

• Use nil for location range of composite value

  Show description for 9458718
  

  darkdrag00nv2

  and

  turbolent

  committed
  9458718

  Copy full SHA for 9458718

• Add missing semicolon

  darkdrag00nv2

  committed
  c962d1c

  Copy full SHA for c962d1c

• Convert and assert needle value at callsite

  darkdrag00nv2

  committed
  5a01dde

  Copy full SHA for 5a01dde

• Store a lazy lookup table for IntegerValue in interpreter

  darkdrag00nv2

  committed
  87cdcc5

  Copy full SHA for 87cdcc5

• Format the error message for sequence moving away from end.

  Show description for ac00e1e
  

  darkdrag00nv2

  and

  SupunS

  committed
  ac00e1e

  Copy full SHA for ac00e1e

• Break mod operation into multiple lines.

  Show description for fc47776
  

  darkdrag00nv2

  and

  SupunS

  committed
  fc47776

  Copy full SHA for fc47776

• Format NewInclusiveRangeValueWithStep call into multiple lines

  Show description for 74af213
  

  darkdrag00nv2

  and

  SupunS

  committed
  74af213

  Copy full SHA for 74af213

• Declare and initialize result on the same line

  Show description for 18b4859
  

  darkdrag00nv2

  and

  SupunS

  committed
  18b4859

  Copy full SHA for 18b4859

• fix lint

  darkdrag00nv2

  committed
  a867b65

  Copy full SHA for a867b65

• return early in contains if needle = lower/upper bound

  darkdrag00nv2

  committed
  e36333e

  Copy full SHA for e36333e

• remove runtime/format/range.go as it not needed

  darkdrag00nv2

  committed
  d36a76e

  Copy full SHA for d36a76e

• Add import/export support for InclusiveRange

  darkdrag00nv2

  committed
  91ea40f

  Copy full SHA for 91ea40f

• Add encoding/decoding/storage tests and fix bugs

  darkdrag00nv2

  committed
  6fd4f27

  Copy full SHA for 6fd4f27

• Add conformance checks for CompositeValue which are not CompositeType

  darkdrag00nv2

  committed
  5386f43

  Copy full SHA for 5386f43

• Add more tests - values, dynamic casting, ccf, json

  darkdrag00nv2

  committed
  d72ddf5

  Copy full SHA for d72ddf5

• Make cachedIntegerValues a global value

  darkdrag00nv2

  committed
  ae29179

  Copy full SHA for ae29179

• Ensure that inner type is an integer in runtime type constructor

  darkdrag00nv2

  committed
  efb0b74

  Copy full SHA for efb0b74

• Remove dead code for super type of InclusiveRangeType

  darkdrag00nv2

  committed
  96fe558

  Copy full SHA for 96fe558

• Take Sema type in param instead of calculating in constructor

  darkdrag00nv2

  committed
  4dac857

  Copy full SHA for 4dac857

• Split out construction of InclusiveRange into a third-private function

  darkdrag00nv2

  committed
  aa36e25

  Copy full SHA for aa36e25

• Add more tests case for ccf encoding/decoding

  darkdrag00nv2

  committed
  6b03f03

  Copy full SHA for 6b03f03

• Remove redundant error from return type

  darkdrag00nv2

  committed
  b1d81fa

  Copy full SHA for b1d81fa

• Return InclusiveRangeType from exportInclusiveRangeType

  darkdrag00nv2

  committed
  cec3966

  Copy full SHA for cec3966

• Update runtime/tests/checker/range_value_test.go

  Show description for 2c9b4a3
  

  darkdrag00nv2

  and

  SupunS

  committed
  2c9b4a3

  Copy full SHA for 2c9b4a3

• use []error instead of []interface{}

  darkdrag00nv2

  committed
  184189b

  Copy full SHA for 184189b

• Update runtime/stdlib/range.go

  Show description for d981a16
  

  darkdrag00nv2

  and

  SupunS

  committed
  d981a16

  Copy full SHA for d981a16

• Update runtime/stdlib/range.go

  Show description for 0a9b4f8
  

  darkdrag00nv2

  and

  SupunS

  committed
  0a9b4f8

  Copy full SHA for 0a9b4f8

• Update runtime/interpreter/value_range.go

  Show description for be883f8
  

  darkdrag00nv2

  and

  SupunS

  committed
  be883f8

  Copy full SHA for be883f8

• Update runtime/interpreter/value_range.go

  Show description for 8440ae7
  

  darkdrag00nv2

  and

  SupunS

  committed
  8440ae7

  Copy full SHA for 8440ae7

• Update runtime/interpreter/value_range.go

  Show description for 44d4d62
  

  darkdrag00nv2

  and

  SupunS

  committed
  44d4d62

  Copy full SHA for 44d4d62

• Update runtime/interpreter/value.go

  Show description for 2b31f2c
  

  darkdrag00nv2

  and

  SupunS

  committed
  2b31f2c

  Copy full SHA for 2b31f2c

• use constructor instead of direct init; also fix compilation error

  darkdrag00nv2

  committed
  e582b6c

  Copy full SHA for e582b6c

• Use TypeValue instead of PathLinkValue in encoding_test

  darkdrag00nv2

  committed
  112114f

  Copy full SHA for 112114f

• Extract sequence direction check to a separate function

  darkdrag00nv2

  committed
  dec5f50

  Copy full SHA for dec5f50

• Predefine list of fields and use in conformance check

  darkdrag00nv2

  committed
  47fc917

  Copy full SHA for 47fc917

• Use type switch for exporting InclusiveRange

  darkdrag00nv2

  committed
  6fbc1a5

  Copy full SHA for 6fbc1a5

• Use type switch in conformance check

  darkdrag00nv2

  committed
  1b1f450

  Copy full SHA for 1b1f450

• Minor nits and add test coverage for Import InclusiveRangeType

  darkdrag00nv2

  committed
  79ff403

  Copy full SHA for 79ff403

• Infer type in importing InclusiveRange, also improve readability of contains implementation

  darkdrag00nv2

  committed
  59b0457

  Copy full SHA for 59b0457

• Refactor InclusiveRange import flow and add more test cases

  darkdrag00nv2

  committed
  16ddd41

  Copy full SHA for 16ddd41

• Add tests for missing failure scenario

  darkdrag00nv2

  committed
  d43a0c5

  Copy full SHA for d43a0c5

• Fix comment

  Show description for e94c03f
  

  darkdrag00nv2

  and

  turbolent

  committed
  e94c03f

  Copy full SHA for e94c03f

• Remove comment.

  Show description for c4c13ff
  

  darkdrag00nv2

  and

  turbolent

  committed
  c4c13ff

  Copy full SHA for c4c13ff

• Use Equal() instead of == and != operators

  Show description for ac26a8b
  

  darkdrag00nv2

  and

  turbolent

  committed
  ac26a8b

  Copy full SHA for ac26a8b

• Extract elementType as a local variable and use.

  Show description for 5b3d817
  

  darkdrag00nv2

  and

  turbolent

  committed
  5b3d817

  Copy full SHA for 5b3d817

• Compare with empty string instead of calculating length of string

  Show description for 7cca141
  

  darkdrag00nv2

  and

  turbolent

  committed
  7cca141

  Copy full SHA for 7cca141

• Rename TestInclusiveRangeConstructionValid -> TestCheckInclusiveRangeConstructionValid

  Show description for bed0e37
  

  darkdrag00nv2

  and

  turbolent

  committed
  bed0e37

  Copy full SHA for bed0e37

• Rename TestInclusiveRangeConstructionInvalid -> TestCheckInclusiveRangeConstructionInvalid

  Show description for 5b187d5
  

  darkdrag00nv2

  and

  turbolent

  committed
  5b187d5

  Copy full SHA for 5b187d5

• Fix typo and build

  darkdrag00nv2

  committed
  257043e

  Copy full SHA for 257043e

• Use decodeCBORArrayWithKnownSize

  darkdrag00nv2

  committed
  1fa90d3

  Copy full SHA for 1fa90d3

• Use inline type instead of CBOR array in InclusiveRange type

  darkdrag00nv2

  committed
  7e5c801

  Copy full SHA for 7e5c801

• Use stricter multiplicity annotation.

  Show description for 80e9f2e
  

  darkdrag00nv2

  and

  turbolent

  committed
  80e9f2e

  Copy full SHA for 80e9f2e

• use r.MemberType directly instead of r.ElementType function

  darkdrag00nv2

  committed
  c7db732

  Copy full SHA for c7db732

• Add TestGetValueForIntegerType

  darkdrag00nv2

  committed
  e2a8436

  Copy full SHA for e2a8436

• Add runtime type tests for InclusiveRangeType

  darkdrag00nv2

  committed
  5de89b1

  Copy full SHA for 5de89b1

• Fix build and tests since we have Arity support now

  darkdrag00nv2

  committed
  f44c8a5

  Copy full SHA for f44c8a5

• Add runtime to load and call contains

  darkdrag00nv2

  committed
  a4d4c96

  Copy full SHA for a4d4c96

Commits on Sep 6, 2023

• Handle each level of multi-level type separately.

  Show description for 1d54260
  

  darkdrag00nv2

  and

  turbolent

  authored
  1d54260

  Copy full SHA for 1d54260

• Remove unnecessary nesting.

  Show description for 131a163
  

  darkdrag00nv2

  and

  turbolent

  authored
  131a163

  Copy full SHA for 131a163

• Extract local variable for invocation.Interpreter

  darkdrag00nv2

  committed
  d169d09

  Copy full SHA for d169d09

• Use StaticType.Equal

  darkdrag00nv2

  committed
  cf5edc8

  Copy full SHA for cf5edc8

Commits on Sep 7, 2023

• Add comment on not metering memory usage of getValueForIntegerType

  darkdrag00nv2

  committed
  e47dbad

  Copy full SHA for e47dbad

• Move GetValueForIntegerType to a new file

  darkdrag00nv2

  committed
  5d1b13f

  Copy full SHA for 5d1b13f

• Make InclusiveRange of values.go a pointer type

  darkdrag00nv2

  committed
  bceada1

  Copy full SHA for bceada1

• Handle MemberType as potentially nil in InclusiveRangeType

  darkdrag00nv2

  committed
  1f96574

  Copy full SHA for 1f96574

Commits on Sep 10, 2023

• Add test case for usage of InclusiveRange without inner type

  darkdrag00nv2

  committed
  e6eeaed

  Copy full SHA for e6eeaed

• Add a mutex in range_value_test.go to protect concurrent access to the cachedIntegerValues map

  darkdrag00nv2

  committed
  5f2ddd8

  Copy full SHA for 5f2ddd8

Commits on Sep 22, 2023

• Add checkParameterizedTypeIsInstantiated

  darkdrag00nv2

  committed
  d97eef6

  Copy full SHA for d97eef6

• Use IsSameTypeKind

  darkdrag00nv2

  committed
  7904b95

  Copy full SHA for 7904b95

Commits on Sep 24, 2023

• Add test case in TestCheckTypeArguments

  darkdrag00nv2

  committed
  8732e3d

  Copy full SHA for 8732e3d

Commits on Oct 3, 2023

• Merge branch 'master' into feature/range-type

  turbolent

  committed
  edf547b

  Copy full SHA for edf547b

• Merge branch 'feature/range-type' into range_type

  turbolent

  committed
  34a43de

  Copy full SHA for 34a43de

• fix qualified string and type ID generation

  turbolent

  committed
  81aed0f

  Copy full SHA for 81aed0f

• improve small integer cache

  turbolent

  committed
  1af52af

  Copy full SHA for 1af52af

• remove unnecessary assertion

  turbolent

  committed
  56c8ac7

  Copy full SHA for 56c8ac7

Commits on Oct 4, 2023

• Separate functions for static type conformance check

  darkdrag00nv2

  committed
  9315a88

  Copy full SHA for 9315a88

• Add runtime test to save and load InclusiveRange in two transactions

  darkdrag00nv2

  committed
  dd77fb7

  Copy full SHA for dd77fb7

Commits on Oct 5, 2023

• Revert the TestRuntimeStorageMultipleTransactionsInclusiveRangeFunction test

  darkdrag00nv2

  committed
  d80f426

  Copy full SHA for d80f426

• Add test case for comparing InclusiveRange

  darkdrag00nv2

  committed
  10f48af

  Copy full SHA for 10f48af

• Add test case for inclusive range instantiation with 2 type args

  darkdrag00nv2

  committed
  64b1b0d

  Copy full SHA for 64b1b0d

Commits on Oct 6, 2023

• Add test case to indicate unsupported storage of inclusive range

  darkdrag00nv2

  committed
  4445c56

  Copy full SHA for 4445c56

Commits on Oct 7, 2023

• Make InclusiveRange type non-storable

  darkdrag00nv2

  committed
  db22c2c

  Copy full SHA for db22c2c

Commits on Oct 9, 2023

• Remove auth account storage test for InclusiveRange

  darkdrag00nv2

  committed
  1ca3adc

  Copy full SHA for 1ca3adc

Commits on Oct 19, 2023

• Merge pull request #2523 from darkdrag00nv2/range_type

  Show description for e523180
  SupunS

  authored
  e523180

  Copy full SHA for e523180

Commits on Oct 22, 2023

• Allow InclusiveRange in for-in loop

  darkdrag00nv2

  committed
  19eb821

  Copy full SHA for 19eb821

Commits on Nov 2, 2023

• use meaningful names

  Show description for ea8ecd4
  

  darkdrag00nv2

  and

  SupunS

  authored
  ea8ecd4

  Copy full SHA for ea8ecd4

• Use meaningful names in inclusiveRangeForInLoopTest struct

  Show description for cfefca3
  

  darkdrag00nv2

  and

  SupunS

  authored
  cfefca3

  Copy full SHA for cfefca3

• Remove export of getFieldAsIntegerValue

  darkdrag00nv2

  committed
  2823012

  Copy full SHA for 2823012

• Asset loop elements instead of just the count

  darkdrag00nv2

  committed
  86b36e8

  Copy full SHA for 86b36e8

• Introduce constructor for InclusiveRangeIterator

  darkdrag00nv2

  committed
  d21296e

  Copy full SHA for d21296e

Commits on Nov 3, 2023

• Review suggestions

  darkdrag00nv2

  committed
  59b1c58

  Copy full SHA for 59b1c58

Commits on Nov 7, 2023

• Use getFieldAsIntegerValue

  Show description for 52ced9b
  

  darkdrag00nv2

  and

  SupunS

  authored
  52ced9b

  Copy full SHA for 52ced9b

• Pass correct location range from call-site

  darkdrag00nv2

  committed
  63a2ee4

  Copy full SHA for 63a2ee4

• Also pass location range in Next

  darkdrag00nv2

  committed
  b512835

  Copy full SHA for b512835

Commits on Nov 8, 2023

• Merge pull request #2892 from darkdrag00nv2/range_type_for_loop

  turbolent

  authored
  7ab492f

  Copy full SHA for 7ab492f

Commits on Dec 1, 2023

• Disallow InclusiveRange<T> if T is non-leaf integer

  darkdrag00nv2

  committed
  d51c035

  Copy full SHA for d51c035

• Fix tests

  darkdrag00nv2

  committed
  f0c20a7

  Copy full SHA for f0c20a7

Commits on Dec 2, 2023

• Remove unused variable

  Show description for ecd3f23
  

  darkdrag00nv2

  and

  turbolent

  authored
  ecd3f23

  Copy full SHA for ecd3f23

• Add ability to specify custom type parameter validation

  darkdrag00nv2

  committed
  7b65121

  Copy full SHA for 7b65121

• pass AST type argument range in Instantiate, also fix tests

  darkdrag00nv2

  committed
  eefb4a1

  Copy full SHA for eefb4a1

• use type argument range in constructor when available

  darkdrag00nv2

  committed
  733cf47

  Copy full SHA for 733cf47

Commits on Dec 5, 2023

• Computate invocation range lazily

  Show description for 2a26bb3
  

  darkdrag00nv2

  and

  turbolent

  authored
  2a26bb3

  Copy full SHA for 2a26bb3

• Fix build

  darkdrag00nv2

  committed
  fa16545

  Copy full SHA for fa16545

• Rename to TypeArgumentsCheck

  darkdrag00nv2

  committed
  d5b746c

  Copy full SHA for d5b746c

• Merge pull request #2959 from darkdrag00nv2/range_type_covariant_subtyping

  Show description for 5d74897
  SupunS

  authored
  5d74897

  Copy full SHA for 5d74897

Commits on Dec 8, 2023

• Make checkParameterizedTypeIsInstantiated recursive

  darkdrag00nv2

  committed
  da3dfc2

  Copy full SHA for da3dfc2

• Remove access modifiers from tests

  Show description for 951a4a7
  

  darkdrag00nv2

  and

  turbolent

  committed
  951a4a7

  Copy full SHA for 951a4a7

• Move checkParameterizedTypeIsInstantiatedTestCase inside the test case

  darkdrag00nv2

  committed
  a1fcc7d

  Copy full SHA for a1fcc7d

• Add more test cases for structs, resources, contracts, enums

  darkdrag00nv2

  committed
  6e05d78

  Copy full SHA for 6e05d78

• Add test cases for struct/resource interface inside a contract

  darkdrag00nv2

  committed
  151816e

  Copy full SHA for 151816e

• Fix typo for lint

  darkdrag00nv2

  committed
  90ede50

  Copy full SHA for 90ede50

• Move instantiation checks to Type interface

  darkdrag00nv2

  committed
  141012f

  Copy full SHA for 141012f

• Declare and use a test function

  darkdrag00nv2

  committed
  460533d

  Copy full SHA for 460533d

• Add NO-OP comments and replace unused parameters with _

  darkdrag00nv2

  committed
  21c83f8

  Copy full SHA for 21c83f8

• Remove redundant check

  darkdrag00nv2

  committed
  f2adc91

  Copy full SHA for f2adc91

• add tests for functrion types

  

  turbolent

  authored and

  darkdrag00nv2

  committed
  a5beda9

  Copy full SHA for a5beda9

• Use function instead of sharing object

  darkdrag00nv2

  committed
  3bd5990

  Copy full SHA for 3bd5990

• Remove unnecessary variable-type assertion

  SupunS

  committed
  f82c07f

  Copy full SHA for f82c07f

Commits on Dec 11, 2023

• Merge pull request #2915 from darkdrag00nv2/range_type_check_parameterized_type_recursive

  Show description for 2a2c540
  SupunS

  authored
  2a2c540

  Copy full SHA for 2a2c540

Commits on Jan 5, 2024

• Merge branch 'master' of https://github.com/onflow/cadence into supun/sync-range-type

  SupunS

  committed
  1a1595c

  Copy full SHA for 1a1595c

• Update inclusive range type to match stable cadence changes

  SupunS

  committed
  6cc271f

  Copy full SHA for 6cc271f

Commits on Jan 9, 2024

• Merge pull request #2995 from onflow/supun/sync-range-type

  turbolent

  authored
  e3eca03

  Copy full SHA for e3eca03

• Merge branch 'master' into feature/range-type

  turbolent

  committed
  e46be51

  Copy full SHA for e46be51

• improve type inference: use bound type parameters for argument expected type

  turbolent

  committed
  4825f92

  Copy full SHA for 4825f92

Commits on Jan 10, 2024

• Merge pull request #3004 from onflow/bastian/2886-improve-type-inference

  turbolent

  authored
  30edca0

  Copy full SHA for 30edca0

• Merge branch 'master' into feature/range-type

  turbolent

  authored
  def44e7

  Copy full SHA for def44e7