Introduce toVariableSized to ConstantSizedArray type
#3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdrag00nv2
requested review from
turbolent,
SupunS and
dsainati1
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3016 +/- ##
==========================================
+ Coverage 79.99% 80.23% +0.23%
==========================================
Files 356 359 +3
Lines 82935 84397 +1462
==========================================
+ Hits 66342 67713 +1371
- Misses 14236 14251 +15
- Partials 2357 2433 +76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Bastian Müller <bastian@turbolent.com>
Co-authored-by: Bastian Müller <bastian@turbolent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #2530
Description
Introduce
toVariableSizedfunction toConstantSizedArraytype. This function will return a variable sized array whose contents are copies of the original constant sized array.Since copy of values are involved, this is not available if the inner type of the constant sized array is a resource.
masterbranchFiles changedin the Github PR explorer