Improve supported entitlements and entitlements inferrence in migration #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolent
added
the
Language Breaking Change
this also improves the inferrence of entitlements in the entitlement migration
turbolent
force-pushed
the
bastian/improve-supported-entitlements
branch
from
41e5b14 to
552f09f
Compare
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit aff3148 Collapsed results for better readability
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
dsainati1
reviewed
Apr 18, 2024
turbolent
changed the title
|
@onflow/cadence PTAL 🙏 |
dsainati1
approved these changes
Apr 24, 2024
SupunS
approved these changes
Apr 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3266 +/- ##
==========================================
+ Coverage 80.77% 80.83% +0.06%
==========================================
Files 380 383 +3
Lines 93663 93887 +224
==========================================
+ Hits 75656 75894 +238
+ Misses 15306 15289 -17
- Partials 2701 2704 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3253
Description
Introduce a new Go type
EntitlementSet(maybe needs a more descriptive name, suggestions very welcome), which is a conjunction of entitlement types, and disjunctions of entitlements. For example, it can represent{A, B, (C | D)}. This allows representing more complex entitlement sets than access/auth entitlement sets can (only conjunction or disjunction of entitlements, e.g.{A, B}OR{A | B})Switch
EntitlementSupportingType.SupportedEntitlementsto returnEntitlementSet.Implementations of the function combine sub-sets – for example, composite type's implementation merges the entitlement sets of all members, and intersection type's implementation merges the entitlement sets of all interface types' supported entitlements. Switching the return type to a set type which is able to represent more complex sets results in less "information loss" in recursive calls.
As a result, when translating the resulting entitlement set to an access, it is possible to get a disjunction now, which was not previously possible.
Given
EntitlementSupportingType.SupportedEntitlementsis used in the entitlements migration and the contract update checker to infer the entitlements/auth, these changes should hopefully result in authorizations that are less permissive than before.masterbranchFiles changedin the Github PR explorer