Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix composite-type explicit-conformances record timing #356

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Fix composite-type explicit-conformances record timing #356

merged 1 commit into from
Sep 29, 2020

Conversation

turbolent
Copy link
Member

Fixes #326

Determine and record explicit composite conformances earlier, before they are used.

@turbolent turbolent self-assigned this Aug 28, 2020
@turbolent
Copy link
Member Author

Thanks @joshuahannan and @AndrewBurian for reporting this 👍

benjaminkvm
benjaminkvm approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@benjaminkvm benjaminkvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Josh! LGTM

@turbolent turbolent merged commit 051091c into master Sep 29, 2020
@turbolent turbolent deleted the bastian/326-fix-composite-type-explicit-conformances-timing branch September 29, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangchiqing zhangchiqing zhangchiqing approved these changes

@benjaminkvm benjaminkvm benjaminkvm approved these changes

@psiemens psiemens Awaiting requested review from psiemens

@jordanschalm jordanschalm Awaiting requested review from jordanschalm

Assignees

@turbolent turbolent

Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource interface conformance issue
3 participants
@turbolent @zhangchiqing @benjaminkvm